feat(install): Add commands install-file and install-vc
#317
Conversation
github-actions
bot
added
the
documentation
jcs090218
changed the title
install-file and install-vc
jcs090218
force-pushed
the
feat/inst-file-and-vc
branch
from
0dca049 to
658b52c
Compare
jcs090218
force-pushed
the
feat/inst-file-and-vc
branch
from
709048e to
3326ca8
Compare
| (defun eask-install-file--packages (files) | ||
| "The file install packages with FILES." | ||
| (let* ((deps (mapcar (lambda (file) | ||
| (list (eask-install-file--guess-name file) file)) |
There was a problem hiding this comment.
This breaks if the package name does not match the folder name, and for tar.gz files.
There was a problem hiding this comment.
This breaks if the package name does not match the folder name, and for tar.gz files.
This sounds reasonable to me. Any suggestions? :)
| (eask-log "Installing %s specified file package%s..." len s) | ||
| (eask-msg "") | ||
| (eask--package-mapc (lambda (dep &rest _) | ||
| (apply #'eask-package-install-file dep)) |
There was a problem hiding this comment.
The --force flag is checked in eask-package-install-file but installed packages are filtered before calling it. I think this means that --force has no effect.
There was a problem hiding this comment.
The --force flag is checked in eask-package-install-file but installed packages are filtered before calling it. I think this means that --force has no effect.
No, those are used for calculating installed packages. It's not the prettiest solution. 😅
There was a problem hiding this comment.
Ah it's used later in a different place.
|
|
||
| (eask-load "core/install-file") | ||
|
|
||
| (defun eask-install-vc--split-sepcs (specs) |
There was a problem hiding this comment.
Doesn't work for e.g. company-mode/company-mode where the package is named company
There was a problem hiding this comment.
Yeah, this probably doesn't work.
This is a rough implementation since I currently doesn't have a good idea to handle multiple specs. 🤔 But I'm looking forward to improve this!
Another attempt for #316.