Refactor company #254
Open
Refactor company #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the biggest benefit is that it adds the small popup on the right with currently selected candidate's docsctring. BREAKING CHANGE: Use `company-posframe-quickhelp` by default instead of `company-doc-buffer`. That includes some key mappings to point to the former instead of the latter.
This is the same binding `helm` uses to switch sources, so I guess backend switch is more anticipated thatn `casual` EdidKit popping up. BREAKING CHANGE: C-o now switches `company` backend when `company` popup is visible.
The `company-abort` is not used in Exordium anymore. The mapping has removed in c3130eb.
I developed package [company-forge] starting with `exordium-company-assignees` and extending its cababilities. The package, available on MELPA, provides completions not only for assignees (users) but also for teams and for issues and pull requests. It also provides icons for completions and uses `quickhelp-string` and `doc-buffer` to provide more information about issues and pull requests. [company-forge] https://github.com/pkryger/company-forge.el
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on refactoring
companycompletion popup. Of notice are:company-posframewhich results in a more feature rich user experience, byproviding a documentation alongside a completion.
company-forgewhich is re-implementation of the small completion backendthat completes assignees. The new version also completes PRs, issues, and
discussions as well as provide a "documentation" for completions.
As usual, a recap of commits below:
refactor(company): Use external company-forge
I developed package [company-forge] starting with
exordium-company-assigneesand extending its cababilities. The package, available on MELPA, provides
completions not only for assignees (users) but also for teams and for issues
and pull requests. It also provides icons for completions and uses
quickhelp-stringanddoc-bufferto provide more information about issuesand pull requests.
[company-forge] https://github.com/pkryger/company-forge.el
fix(company): Remove superfluous company-abort declaration
The
company-abortis not used in Exordium anymore. The mapping has removed inc3130eb.
feat(company)!: Use C-o to switch backends
This is the same binding
helmuses to switch sources, so I guess backendswitch is more anticipated thatn
casualEdidKit popping up.BREAKING CHANGE: C-o now switches
companybackend whencompanypopup isvisible.
feat(company)!: Add company-posframe
I think the biggest benefit is that it adds the small popup on the right with
currently selected candidate's docsctring.
BREAKING CHANGE: Use
company-posframe-quickhelpby default instead ofcompany-doc-buffer. That includes some key mappings to point to the formerinstead of the latter.