Add mastodon to legacy release #463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a social media link to our new mastodon account. It also adds `rel="me"` to the social media links, which is a semantic hint that these are pages about EmberJS on other sites, and which should cause our Mastodon profile to show as "Verified" as the owner of emberjs.com.
✅ Deploy Preview for ember-styleguide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Some tests with 'continue-on-error: true' have failed:
|
mansona
approved these changes
Jun 1, 2023
|
Discussed this in the Learning Team meeting: I'm going to try to get this merged and released so it's no longer blocked 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember API docs is on v2.6.0-0 of this library. We need to backport adding a link to mastodon, as a stopgap measure between now and when that app can be updated.
This PR exists for comparison purposes with v2.6.0-0. If it is accepted, please tag the branch as v2.6.0-1 and run a release.
Here are sample release notes, the content for the last 2.6 backport: https://github.com/ember-learn/ember-styleguide/releases/tag/v2.6.0-0