Update finding Record section in ember-data guides to teach request service#2030
Update finding Record section in ember-data guides to teach request service#2030MehulKChaudhari wants to merge 7 commits intoember-learn:masterfrom
finding Record section in ember-data guides to teach request service#2030Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Baltazore
left a comment
Baltazore
left a comment
There was a problem hiding this comment.
Great job overall, still have some questions to resolve.
Baltazore
left a comment
Baltazore
left a comment
There was a problem hiding this comment.
code parts looks correct, added minor change requests for consistency.
someone please review is linguistically all sounds good
| Use [`store.findRecord()`](https://api.emberjs.com/ember-data/release/classes/Store/methods/findRecord?anchor=findRecord) to retrieve a record by its type and ID. | ||
| This will return a promise that fulfills with the requested record: | ||
| Use [`findRecord()`](https://api.emberjs.com/ember-data/5.3/functions/@ember-data%2Fjson-api%2Frequest/findRecord) to retrieve a record by its type and ID. | ||
| This will return a single `record` or a `array` depends upon the response from server: |
There was a problem hiding this comment.
we should probably introduce builders / the concept of the request first, because this function won't do this on its own and this particular one builds a json:api specific request.
There was a problem hiding this comment.
Umm, that Makes sense. But the builder or the concept of the request will be in a separate document, right? Since this is specific to finding records.
There was a problem hiding this comment.
there's a chicken/egg problem, unsure if its better in a separate file or not because its likely you want to introduce them together
MehulKChaudhari
force-pushed
the
new-emberData/finding-records
branch
from
db66780 to
1ccbdb0
Compare
3 participants
This is to make changes to this page
Changes related to ember-data request service paradigm RFC