Skip to content

fix Prototype-polluting assignment ('Code Injection') #20895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix Prototype-polluting assignment ('Code Injection') #20895

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7df5f
Update index.ts
odaysec Apr 21, 2025
4270765
Update packages/@ember/engine/index.ts
odaysec Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@ember/engine/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@ export function buildInitializerMethod<
B extends 'initializers' | 'instanceInitializers',
T extends B extends 'initializers' ? Engine : EngineInstance,
>(bucketName: B, humanName: string) {
if (bucketName === '__proto__' || bucketName === 'constructor' || bucketName === 'prototype') {
throw new Error(`Invalid bucketName: ${bucketName}`);
}
return function (this: typeof Engine, initializer: Initializer<T>) {
// If this is the first initializer being added to a subclass, we are going to reopen the class
// to make sure we have a new `initializers` object, which extends from the parent class' using
Expand Down