Skip to content

Adds support for DKIM flags. fixes #44 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds support for DKIM flags. fixes #44 #50

wants to merge 1 commit into from

Conversation

gowthamgts
Copy link

This adds support for both y and s flags. s is tested. wanted to confirm the approach to y flag.

@gowthamgts gowthamgts mentioned this pull request Jul 31, 2021
Open
foxcpp
foxcpp reviewed Jul 31, 2021
View reviewed changes
Copy link
Contributor

@foxcpp foxcpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if t=y is used, verification should be performed as usual (to test DKIM) but the result shloud not be used in any policy mechanisms (e.g. DMARC). I would add Testing flag to returned verification objects.

@mimi89999
Copy link
Contributor

Hello,
What's the status of this pull request? If there are doubts about how the y flag should be treated, maybe the PR could only add support for s and the other one could be added later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@foxcpp foxcpp foxcpp left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gowthamgts @mimi89999 @foxcpp