Add support for postfix XFORWARD command. #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have need of support, and would like to contribute back if it fits in. XFORWARD is not an RFC standard (https://www.postfix.org/XFORWARD_README.html) , but it's used in postfix in more complicated proxy setups and content filters, and is much more reliable than trying to partially read the DATA of a message to parse a Received header (also, I dont like adding those for intermediate servers). I've tried to match existing style as much as I could.
The downside? Adding the function to the session interface breaks existing code, requiring at minimum a noop function in consumers. I didn't see an easy way around this and it's very easy to add to release notes, but it is a breaking change to existing code, which is never nice.
There's probably some more room for improvement (e.g. the permitted attributes are not an exhaustive list here), but wanted to submit this as an early PR to gauge appetite for it - I've tested it as working in my application, and would be perfectly happy to merge as-is. Here are some examples from my system logging (everything on a local system):