h2m: add optional stats to header-to-metadata filter #40464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Rohit Agrawal <[email protected]>
|
may need to wait |
wbpcode
reviewed
Aug 9, 2025
Comment on lines
229
to
231
| if (config->stats().has_value()) { | ||
| config->stats().value().base64_decode_failed_.inc(); | ||
| } |
There was a problem hiding this comment.
I will inclined to createa method in the Config to accept the two enums, one enum for event, one enum for traffic direction.
Then handle all this logic in same method to avoid this if (config->stats().has_value()) everywhere. If we need to add new stats in the future, it would much simpler also.
|
/lgtm api |
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
feat-stats-h2m
branch
from
4e356ae to
663bd8f
Compare
wbpcode
reviewed
Aug 14, 2025
source/extensions/filters/http/header_to_metadata/header_to_metadata_filter.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds optional stats collection to Header-To-Metadata filter when enabled. It's quite helpful to understand when the header was missing, how many rules get processed, failures etc.
Commit Message: h2m: add optional stats to header-to-metadata filter
Additional Description: Adds optional stats collection to Header-To-Metadata filter when enabled.
Risk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: Added