Skip to content

Empty command operator DOWNSTREAM_TLS_SESSION_ID (for including X-SSL-SESSION-ID header) #8595

Description

@V1cenZ

Description:

When using Envoy Gateway with Gateway API, most substitution format operators work as expected when setting request headers via ClientTrafficPolicy. However, the %DOWNSTREAM_TLS_SESSION_ID% operator always resolves to an empty value.

This happens even when TLS session resumption is explicitly enabled with session-id or session-tickets.

session:
  resumption:
    stateless: {} (also tested with statefull mode)

DOWNSTREAM_TLS_SESSION_ID is included in the command operators that should be supported:

https://www.envoyproxy.io/docs/envoy/latest/configuration/advanced/substitution_formatter#config-advanced-substitution-operators

Repro steps:

The issue occurs with the following ClientTrafficPolicy:

apiVersion: gateway.envoyproxy.io/v1alpha1
kind: ClientTrafficPolicy
metadata:
  name: client-traffic-policy
  namespace: envoy-gateway-system
spec:
  targetRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: eg
    sectionName: https-443
    session:
      resumption:
        stateless: {}
  headers:
    earlyRequestHeaders:
      set:
      - name: "X-Client-IP"
        value: "%DOWNSTREAM_REMOTE_ADDRESS_WITHOUT_PORT%"
      - name: "X-Real-IP"
        value: "%DOWNSTREAM_REMOTE_ADDRESS_WITHOUT_PORT%"
      - name: "X-Original-Forwarded-For"
        value: "%REQ(X-Forwarded-For)%"
      - name: "X-SSL-PROTOCOL"
        value: "%DOWNSTREAM_TLS_VERSION%"
      - name: "X-SSL-CIPHER"
        value: "%DOWNSTREAM_TLS_CIPHER%"
      - name: "X-SSL-SESSION-ID"
        value: "test-%DOWNSTREAM_TLS_SESSION_ID%-end"


*Environment*:
 
Using 1.7.0 envoy Gateway version.

*Logs*:

X-SSL-Protocol and X-SSL-Cipher are correctly received by the backend, but X-SSL-Session-ID is not.

X-SSL-Protocol: TLSv1.3
X-SSL-Cipher: TLS_AES_256_GCM_SHA384
X-SSL-Session-ID: test--end

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions