Skip to content

Conversation

sudiptob2
Copy link
Contributor

@sudiptob2 sudiptob2 commented Jul 21, 2025

Fixes #6535

This PR adds support for configuring the service name used in Envoy's tracing configuration through the serviceName field in the EnvoyProxy spec.

Note: The serviceName field is not supported for Zipkin tracing providers. For Zipkin, the service name is always derived from Envoy's --service-cluster flag (typically namespace/name format).

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (c3abe4e) to head (99bbfe7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6568      +/-   ##
==========================================
+ Coverage   70.86%   70.88%   +0.02%     
==========================================
  Files         224      224              
  Lines       38733    38736       +3     
==========================================
+ Hits        27447    27457      +10     
+ Misses       9697     9692       -5     
+ Partials     1589     1587       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudiptob2 sudiptob2 marked this pull request as ready for review July 21, 2025 18:27
@sudiptob2 sudiptob2 requested a review from a team as a code owner July 21, 2025 18:27
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
@sudiptob2 sudiptob2 force-pushed the feat/allow-servicename branch from 8002061 to 99bbfe7 Compare July 23, 2025 00:09
@arkodg arkodg requested a review from zirain July 23, 2025 23:48
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 23, 2025
@zirain
Copy link
Member

zirain commented Jul 24, 2025

/retest

@arkodg arkodg merged commit 34ee980 into envoyproxy:main Jul 24, 2025
47 of 50 checks passed
@sudiptob2 sudiptob2 deleted the feat/allow-servicename branch August 3, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring service_name in tracing via EnvoyProxy spec

4 participants