feat: gRPC streaming timeout #7194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add StreamTimeout field to HTTPTimeout struct in BackendTrafficPolicy to enable configuration of timeouts specifically for gRPC streaming requests. Key changes: 1. Add StreamTimeout field to api/v1alpha1/timeout_types.go 2. Add StreamTimeout field to internal/ir/xds.go HTTPTimeout 3. Update buildClusterSettingsTimeout to process StreamTimeout 4. Update XDS translation to use StreamTimeout for gRPC routes (IsHTTP2) 5. Add getEffectiveTimeout function to prioritize StreamTimeout for gRPC routes When StreamTimeout is set to 0s, timeouts are disabled for streaming requests. This resolves the 15-second timeout limitation for gRPC streaming calls. Signed-off-by: Shivam Mittal <[email protected]>
Update CRDs, Helm charts, and other generated files to include the new StreamTimeout field in HTTPTimeout structs. Signed-off-by: Shivam Mittal <[email protected]>
Signed-off-by: shiavm006 <[email protected]>
Signed-off-by: jukie <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
+ Coverage 72.02% 72.04% +0.02%
==========================================
Files 230 230
Lines 33405 33420 +15
==========================================
+ Hits 24059 24079 +20
+ Misses 7594 7591 -3
+ Partials 1752 1750 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
jukie
force-pushed
the
grpc-streaming-timeout
branch
from
e1ccce4 to
297892f
Compare
|
/retest |
zirain
reviewed
Oct 14, 2025
Signed-off-by: jukie <[email protected]>
jukie
force-pushed
the
grpc-streaming-timeout
branch
from
056651d to
506b768
Compare
Signed-off-by: jukie <[email protected]>
|
/retest |
arkodg
reviewed
Oct 15, 2025
arkodg
reviewed
Oct 15, 2025
Signed-off-by: Isaac <[email protected]>
Signed-off-by: jukie <[email protected]>
Signed-off-by: Isaac <[email protected]>
Signed-off-by: jukie <[email protected]>
arkodg
reviewed
Oct 24, 2025
arkodg
reviewed
Oct 24, 2025
Signed-off-by: jukie <[email protected]>
arkodg
previously approved these changes
Oct 24, 2025
|
/retest |
Signed-off-by: Isaac <[email protected]>
|
/retest |
1 similar comment
|
/retest |
6 tasks
guydc
approved these changes
Oct 29, 2025
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Carries over changes from stale PR #6508
with linting and full implementation ofwill handle in a follow-upGrpcTimeoutHeaderMaxWhich issue(s) this PR fixes:
Fixes #5446
Release Notes: Yes