feat: add support for contrpl plane tracer#8551
feat: add support for contrpl plane tracer#8551zirain wants to merge 10 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Signed-off-by: Shreemaan Abhishek <shreemaanabhishek@apache.org>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (15.49%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8551 +/- ##
==========================================
- Coverage 74.13% 73.98% -0.15%
==========================================
Files 242 243 +1
Lines 37669 37726 +57
==========================================
- Hits 27925 27911 -14
- Misses 7787 7859 +72
+ Partials 1957 1956 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
internal/traces/register.go
Outdated
| return nil | ||
| } | ||
|
|
||
| if configObj.Protocol == egv1a1.HTTPProtocol { |
There was a problem hiding this comment.
The gRPC and HTTP exporter blocks are nearly identical only the exporter creation differs. Is there another way to represent that? Maybe extract the common TracerProvider setup into a helper and only branch on the exporter creation? If I am not misaken I think if configObj.Protocol is neither GRPCProtocol nor HTTPProtocol, the function will silently return nil
internal/traces/register.go
Outdated
| // Create OTLP HTTP exporter | ||
| exporter, err := otlptracehttp.New(ctx, | ||
| otlptracehttp.WithEndpoint(endpoint), | ||
| otlptracehttp.WithInsecure(), |
There was a problem hiding this comment.
It may be worth a comment or noting somewhere that there is a TLS limitation for both http and grpc
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
3 participants
Move #7859 forward, base on @shreealt work.