Skip to content

chore: update basic auth error status#8589

Open
zhaohuabing wants to merge 1 commit intoenvoyproxy:mainfrom
zhaohuabing:chore-basic-auth-warning
Open

chore: update basic auth error status#8589
zhaohuabing wants to merge 1 commit intoenvoyproxy:mainfrom
zhaohuabing:chore-basic-auth-warning

Conversation

@zhaohuabing
Copy link
Member

This PR makes the “basic auth secret not found” error clearer to avoid confusion (e.g., #8588).

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner March 25, 2026 03:55
@netlify
Copy link

netlify bot commented Mar 25, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 6d85e22
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69c35ccaf8d15800086da34e

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.34%. Comparing base (a5535c4) to head (6d85e22).

Files with missing lines Patch % Lines
internal/gatewayapi/securitypolicy.go 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8589      +/-   ##
==========================================
- Coverage   74.40%   74.34%   -0.07%     
==========================================
  Files         243      243              
  Lines       38143    38143              
==========================================
- Hits        28381    28357      -24     
- Misses       7776     7799      +23     
- Partials     1986     1987       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing requested a review from a team March 25, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants