Skip to content

Add redirect_uri to access_token params #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Add redirect_uri to access_token params #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/auth/oauth_gems.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,5 +226,10 @@ def authorize_params
end
end
end

def callback_url
options[:redirect_uri] || (full_host + script_name + callback_path)
Copy link
Owner

@erickguan erickguan Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, should call super instead of (full_host + script_name + callback_path)

Copy link
Owner

@erickguan erickguan Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems omniauth-oauth2 has some problems. Anyway, it's not relevant here. omniauth/omniauth-oauth2#100

Copy link
Contributor Author

@gdong42 gdong42 Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, should call super instead of (full_host + script_name + callback_path)

not working... just tested with my branch https://github.com/gdong42/discourse-chinese-localization-pack/tree/temp
not sure if I'm using super in the correct way, though - I'm quite new to Ruby
I guess it might be due to the super callback_url was removed in the change that the pull request you posted was trying to add back

Copy link
Owner

@erickguan erickguan Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok...I don't get their problem. I'm happy to merge this. Thank you!

end

end