Michal/mnesia/fix-handling-node-name-as-table-name/otp-19745

[Mikaka27]

The problem is that mnesia_decision table stores multiple tuple/record types, and the key is on position 2.
What can be stored:

• {mnesia_down, Node, Date, Time}
• {master_nodes, Tab, Nodes}
• -record(decision, {tid, outcome, disc_nodes, ram_nodes}).
• {trans_tid, serial, Serial}

If table name is equal to node name, the {mnesia_down, ...} and {master_nodes, ...} can conflict with each other, and {mnesia_down, ...} can be interpreted as {master_nodes, ...} causing crash in mnesia.

[github-actions]

CT Test Results

  2 files   61 suites   19m 17s ⏱️
694 tests 543 ✅ 151 💤 0 ❌
749 runs  583 ✅ 166 💤 0 ❌

Results for commit 0c8f423.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• No Windows Installer found

// Erlang/OTP Github Action Bot

[Copilot]

Pull Request Overview

This PR fixes a bug in Mnesia where using a node name as a table name could cause crashes due to conflicting keys in the mnesia_decision table. The fix wraps node names and table names with tagged tuples to ensure unique keys.

• Changes the key format in mnesia_decision table from raw names to tagged tuples ({node, Node} and {tab, Tab})
• Updates all related functions to handle the new key format consistently
• Adds conversion functions for backward compatibility with disk format
• Includes a regression test to verify the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/mnesia/src/mnesia_recover.erl	Implements the core fix by wrapping node/table names in tagged tuples and adding conversion functions
lib/mnesia/test/mnesia_recovery_test.erl	Adds regression test to verify node names can be used as table names

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}