- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3k
michal/observer/fix-zero-fault-issue-in-etop-suite #10148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
michal/observer/fix-zero-fault-issue-in-etop-suite #10148
Conversation
| CT Test Results  2 files   15 suites   7m 27s ⏱️ Results for commit 75014bc. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
 // Erlang/OTP Github Action Bot | 
| Changed to draft for now since it caused failure in the CI, need to investigate more. | 
7e3b4b1    to
    9181630      
    Compare
  
    9181630    to
    c5ff40b      
    Compare
  
    c5ff40b    to
    1417b0c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a race condition in the etop module's stop functionality that was causing issues in the zerofault CI suite. The changes ensure proper synchronization when stopping etop processes by monitoring them and waiting for their termination.
- Replaces fire-and-forget message sending with proper process monitoring
- Ensures reader process termination is properly awaited before continuing
- Adds defensive checks for process aliveness before attempting to stop them
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
75014bc    to
    5759d34      
    Compare
  
    
This caused issue in our zerofault CI suite: https://github.com/erlang/backlog/issues/701