Skip to content

Conversation

@Mikaka27
Copy link
Contributor

This caused issue in our zerofault CI suite: https://github.com/erlang/backlog/issues/701

@Mikaka27 Mikaka27 changed the base branch from master to maint August 29, 2025 15:23
@Mikaka27 Mikaka27 requested a review from Copilot August 29, 2025 15:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

CT Test Results

  2 files   15 suites   7m 27s ⏱️
164 tests 160 ✅ 4 💤 0 ❌
181 runs  177 ✅ 4 💤 0 ❌

Results for commit 75014bc.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

This comment was marked as outdated.

@Mikaka27 Mikaka27 self-assigned this Aug 29, 2025
@Mikaka27 Mikaka27 added team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Aug 29, 2025
@Mikaka27 Mikaka27 marked this pull request as draft September 1, 2025 11:15
@Mikaka27
Copy link
Contributor Author

Mikaka27 commented Sep 1, 2025

Changed to draft for now since it caused failure in the CI, need to investigate more.

@Mikaka27 Mikaka27 force-pushed the michal/observer/fix-zero-fault-issue-in-etop-suite branch from 7e3b4b1 to 9181630 Compare September 1, 2025 15:05
@Mikaka27 Mikaka27 marked this pull request as ready for review September 1, 2025 15:06
@Mikaka27 Mikaka27 requested a review from Copilot September 1, 2025 15:06

This comment was marked as outdated.

@Mikaka27 Mikaka27 force-pushed the michal/observer/fix-zero-fault-issue-in-etop-suite branch from 9181630 to c5ff40b Compare September 1, 2025 15:35
@Mikaka27 Mikaka27 requested a review from Copilot September 1, 2025 15:35

This comment was marked as outdated.

@Mikaka27 Mikaka27 force-pushed the michal/observer/fix-zero-fault-issue-in-etop-suite branch from c5ff40b to 1417b0c Compare September 1, 2025 15:39
@Mikaka27 Mikaka27 requested a review from Copilot September 1, 2025 15:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a race condition in the etop module's stop functionality that was causing issues in the zerofault CI suite. The changes ensure proper synchronization when stopping etop processes by monitoring them and waiting for their termination.

  • Replaces fire-and-forget message sending with proper process monitoring
  • Ensures reader process termination is properly awaited before continuing
  • Adds defensive checks for process aliveness before attempting to stop them

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mikaka27 Mikaka27 requested a review from Whaileee September 1, 2025 15:41
@Mikaka27 Mikaka27 added the testing currently being tested, tag is used by OTP internal CI label Sep 1, 2025
@Mikaka27 Mikaka27 force-pushed the michal/observer/fix-zero-fault-issue-in-etop-suite branch from 75014bc to 5759d34 Compare September 8, 2025 13:12
@Mikaka27 Mikaka27 merged commit 5fea6c4 into erlang:maint Sep 8, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants