Add link flag -undefined dynamic_lookup for macOS build (fixes GH-4) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatriceBlin
force-pushed
the
fix-build-macos
branch
from
ea3f1e9 to
0aff63a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4
To be checked when I get an hand on a macOS device.
I took the "if" check from LLVM: 15.x/libcxxabi/CMakeLists.txt#L412
llvm/llvm-project@6f8d62d
It's unclear if it's related to clang only, or if we should expect macOS to only build with clang or even if "-undefined dynamic_lookup" would be supported in the future.