refactor: use getLocFromIndex in no-space-in-emphasis
#553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
commented
Oct 5, 2025
mdjermanovic
reviewed
Oct 6, 2025
mdjermanovic
deleted the
refactor-use-getlocfromindex-in-no-space-in-emphasis
branch
DMartens
reviewed
Oct 7, 2025
| * @param {boolean} checkStrikethrough Whether to include strikethrough markers. | ||
| * @returns {RegExp} The marker pattern. | ||
| */ | ||
| function createMarkerPattern(checkStrikethrough) { |
There was a problem hiding this comment.
Can we also remove the function as part of this refactoring as no regular expression is dynamically created?
DMartens
reviewed
Oct 7, 2025
| "paragraph:exit"(node) { | ||
| bufferManager.exit(node); | ||
| }, | ||
| ":matches(heading, paragraph, tableCell):exit"( |
There was a problem hiding this comment.
Suggested change
| ":matches(heading, paragraph, tableCell):exit"( | |
| "heading, paragraph, tableCell:exit"( |
The :matches pseudo-selector is not required.
DMartens
reviewed
Oct 7, 2025
| /** @type {RegExpExecArray | null} */ | ||
| let match; | ||
|
|
||
| while ((match = markerPattern.exec(maskedText)) !== null) { |
There was a problem hiding this comment.
We could use String#matchAll instead of using while with exec:
Suggested change
| while ((match = markerPattern.exec(maskedText)) !== null) { | |
| for (const match of maskedText.matchAll(markerPattern) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR originated from #536. While working on that, I found the scope had become too large, so I split this refactoring into a separate PR.
In this PR, I've used the native
getLocFromIndexmethod added in #376 instead of the customfindOffsetsutil.Notable changes:
findOffsetsutil with the nativegetLocFromIndex.findEmphasisMarkers,checkEmphasis,bufferManager, and other helper functions directly into the ESQuery selector to simplify the code.What changes did you make? (Give an overview)
In this PR, I've used the native
getLocFromIndexmethod added in #376 instead of the customfindOffsetsutil.Related Issues
Ref: #376, #536
Is there anything you'd like reviewers to focus on?
I personally don't prefer large git diffs, but this time there was a lot of room to simplify the logic (resulting in −113 lines of code), so I inevitably produced a large diff.
My main focus while working was reducing unnecessarily nested helper functions and simplifying the line/column <-> offset translation logic.