-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[wifi] Clarify fast_connect behavior and add hidden network documentation #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves WiFi component documentation by clarifying the behavior of fast_connect and adding comprehensive guidance for hidden network configuration. The changes address user confusion about when scanning occurs and provide clear instructions for properly configuring hidden networks.
Key changes:
- Corrected
fast_connectdescription to remove the misleading claim that it's required for hidden networks - Added clarification that ESPHome still scans after failed connection attempts even with
fast_connectenabled - Documented the proper use of
hidden: truefor hidden networks with warnings about signal strength limitations
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughDocumentation for the WiFi component clarifies fast_connect and hidden network behavior, adds notes about fallback scan behavior when fast_connect fails, includes TIPs about signal-selection trade-offs for hidden SSIDs, and adds YAML examples showing how to configure hidden networks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/components/wifi.md (1)
110-111: Consolidate signal strength phrasing for consistency.The same limitation about connecting to weaker APs is described with two different phrasings:
- Line 111: "may not connect to the AP with the best signal strength"
- Lines 312-313: "potentially resulting in connections to APs with weaker signals"
While both convey the same idea, using a consistent phrase across both the NOTE and TIP blocks would improve clarity. Consider aligning them to use one consistent wording (ideally the clearer "may not connect to the AP with the best signal strength" as suggested in the prior review).
Apply this diff to align the phrasing in the TIP block:
- Note that when connecting to a hidden network, ESPHome cannot determine which access point has the best signal strength, potentially resulting in connections to APs with weaker signals when multiple APs share the same SSID. + Note that when connecting to a hidden network, ESPHome cannot determine which access point has the best signal strength and may not connect to the AP with the best signal when multiple APs share the same SSID.Also applies to: 309-313
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/components/wifi.md(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
content/components/wifi.md
🧠 Learnings (1)
📚 Learning: 2025-05-12T00:02:50.869Z
Learnt from: jesserockz
Repo: esphome/esphome-docs PR: 4901
File: changelog/2025.4.0.rst:124-126
Timestamp: 2025-05-12T00:02:50.869Z
Learning: In the ESPHome changelog structure, the "All changes" section should have the `:open:` attribute to be expanded by default, but the "Dependency Changes" section should NOT have this attribute as it should remain collapsed by default.
Applied to files:
content/components/wifi.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (2)
content/components/wifi.md (2)
99-111: Clarifiedfast_connectbehavior and fallback scan behavior is accurate.The removal of "required for hidden networks" is correct since
hidden: trueis the recommended approach. The NOTE block properly explains that fast_connect still performs a scan on connection failure and directs hidden network users to use thehidden: trueconfiguration option.
320-328: Hidden network example is clear and helpful.The YAML example properly demonstrates the configuration of a hidden network with the
hidden: trueflag and complements the preceding documentation well.
Description:
This PR improves the WiFi component documentation to clarify the relationship between
fast_connectandhiddennetwork options:Clarifies
fast_connectbehavior: Updated the description to explain that whilefast_connectskips the initial scan, if the connection attempt fails, ESPHome will still perform a scan to find available networks. This addresses user confusion when devices withfast_connect: truestill scan after failed connection attempts.Adds guidance for hidden networks: Added a note explaining that users who want to completely skip scanning (e.g., for hidden networks) should use
hidden: trueon the network configuration.Documents signal strength limitation: Added a tip warning that marking networks as hidden prevents ESPHome from finding the best access point by signal strength, which may result in connections to APs with weaker signals when multiple APs share the same SSID.
Adds example: Added a concrete YAML example showing how to configure a hidden network.
Related issue (if applicable): fixes esphome/esphome#12105
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.