Skip to content

feat(touch): Support all touch versions in NG driver #11643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR introduces a unified touch sensor driver that supports all ESP32 variants (ESP32, ESP32-S2, ESP32-S3, ESP32-P4) with improved reliability and maintainability. The legacy touch implementation has been replaced with the modern NG driver, and all related examples and tests have been updated accordingly.

BREAKING CHANGE:
For ESP32 touchInterruptSetThresholdDirection(bool mustbeLower) can now be used only before setting up the touch pin.

Tests scenarios

Tested using ESP32, ESP32-S2 and ESP32-S3 all 3 examples.
Was failing on S2/S3 in the touch test locally now on interrupt or on single pin reading.

Related links

Closes #11637

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jul 25, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y requested review from lucasssvaz and a team as code owners July 25, 2025 16:35
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Jul 25, 2025
Copy link
Contributor

github-actions bot commented Jul 25, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 04459fa

Copy link
Contributor

github-actions bot commented Jul 25, 2025

Test Results

144 files  144 suites   40m 45s ⏱️
 43 tests  41 ✅ 0 💤 2 ❌
443 runs  436 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 04459fa.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: In Progress ⚠️ Issue is in progress label Jul 25, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the hil_test Run Hardware Tests label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. hil_test Run Hardware Tests Status: In Progress ⚠️ Issue is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning message during compilation
1 participant