-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(eth): Add support for LAN867X ETH PHY #11843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 76 files 76 suites 13m 11s ⏱️ Results for commit 065f920. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request adds support for the LAN867x Ethernet PHY to the ESP32 platform. The changes include updating dependencies, conditionally enabling code for the new PHY, and integrating it into the Ethernet library's initialization and configuration logic.
LAN867x PHY Support Integration:
espressif/lan867x
as a dependency inidf_component.yml
, limited to ESP32 and ESP32P4 targets.ETH_PHY_LAN867X_SUPPORTED
macro inETH.h
whenesp_eth_phy_lan867x.h
is available, enabling conditional compilation for LAN867x support.ETH_PHY_LAN867X
to theeth_phy_type_t
enum, making it selectable as a PHY type.esp_eth_phy_lan867x.h
and added case handling forETH_PHY_LAN867X
in the Ethernet initialization logic, allowing the library to instantiate and use the LAN867x PHY. [1] [2]Closes: espressif/esp32-arduino-lib-builder#319