Conversation
test/es6.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe.skip('dynamic import', function() { |
There was a problem hiding this comment.
Couldn’t you get these tests to work by putting in object literals with the ast instead of blocking on espree?
There was a problem hiding this comment.
I hadn't tried that. I'll give it a go
…ng on espree having dynamic import support
|
@michaelficarra, does this LGTY? |
|
@papandreou No, this conflicts with the currently proposed tree structure for dynamic imports: https://github.com/estree/estree/pull/198/files. We must wait until that is merged to support dynamic imports, and change this PR to match the estree spec. |
Aligned the PR now 🤗 |
|
estree/estree#198 was merged now 😌 @michaelficarra, can we move forward? |
|
@michaelficarra, sorry to spam you so much everywhere, but could we have a new npm release with this included? |
|
@papandreou Published |
3 participants
Attempt to support https://tc39.github.io/proposal-dynamic-import/
I have a local setup where I run estraverse on the output of Acorn with the acorn-dynamic-import installed through estraverse with this patch applied. That works fine.
I added some commented out tests, which are not working at the moment. This is primarily because espree doesn't know how to parse dynamic imports yet. The tests are probably not correct either because I'm not fully aware of the expected behavior
Relates to #98
--- Update ---
I switched the tests to avoid the espree dependency, which enables them to pass