.github: add 32-bit CI targets #32911
Conversation
|
Instead of adding custom workflow steps, why don't we finish #32632 and then use it for the GitHub action as well? |
|
because it's going to take a long time to merge it, and we already broke the build once last week and didn't even notice. I was hoping this would serve as a basis for the other one, tbh. |
|
No, the other one should serve as the basis for this. In #32632, we are adding a command to ci.go that builds keeper for all defined targets. We should run this command on GitHub actions for pull request CI. |
gballet
changed the title
.github/workflows/go.yml
Outdated
| go-version: '1.25' | ||
| cache: false | ||
|
|
||
| - name: Run tests |
There was a problem hiding this comment.
seems to be only building and not actually running any test
There was a problem hiding this comment.
good catch. The build was initially the problem, but I guess we need to run the tests as well just to make sure
gballet
requested review from
fjl,
rjl493456442 and
zsfelfoldi
as code owners
fjl
changed the title
4 participants
This adds two new CI targets. One is for building all supported keeper executables, the other is for running unit tests on 32-bit Linux.