Skip to content

Fix Rename Workspace Test #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Fix Rename Workspace Test #6248

wants to merge 37 commits into from
+495 −354

Conversation

joeizang
Copy link
Collaborator

fixes #6235

@joeizang joeizang self-assigned this Aug 12, 2025
@joeizang joeizang added the WIP label Aug 12, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 12, 2025 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 982c1cd
🔍 Latest deploy log https://app.netlify.com/projects/remixproject/deploys/68a5be3114952100080b0bd4
😎 Deploy Preview https://deploy-preview-6248--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

joeizang and others added 20 commits August 14, 2025 13:42
@joeizang
Merge branch 'master' into fix-rename-workspacetest
a7e828e
@joeizang
Merge branch 'master' into fix-rename-workspacetest
ea606e8
fix contract execution test
02b423d
fix test
3392271
mark test
cdcaa79
@joeizang
Merge branch 'master' into fix-rename-workspacetest
a763f3a
fix plugin api
c50f4b8
fix flaky tests
8ef1b2d
fix css to hide tooltips and scam alert. update scrollInto command
8fed31c
add topbar to plugin api test
366f478
change button text divider to dash to fix test. restore port number
6abfed2
@joeizang
Merge branch 'master' into fix-rename-workspacetest
1360358
fix script-runner tests. fix plugin api test
6a92f8f
fix plugin api test
d693338
@joeizang
Merge branch 'master' into fix-rename-workspacetest
96b4c4d
change port temp
bba9414
fix getWorkspaces using topbar
d5ad927
revert port number
b321d8a
fix script runner flakiness
6131473
fix pluginapi and scriptrunner tests
576170a
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Aug 19, 2025
@joeizang joeizang requested a review from Aniket-Engg August 19, 2025 14:44
Aniket-Engg
Aniket-Engg reviewed Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-19 at 9 36 18 PM
  • Dropdown width is smaller than the parent element
  • clicking on Create new workspace doesn't close the dropdown
Screenshot 2025-08-19 at 9 37 30 PM

@joeizang joeizang requested a review from Aniket-Engg August 20, 2025 10:14
Aniket-Engg
Aniket-Engg reviewed Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-20 at 5 07 05 PM
  • There is no scroll for workspaces ad before
Screenshot 2025-08-20 at 5 07 37 PM
  • Git workspace is appearing like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniket-Engg Aniket-Engg Aniket-Engg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@joeizang joeizang

Labels
ready-to-review PR ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix workspace rename delete e2e
2 participants
@joeizang @Aniket-Engg