Skip to content

Conversation

@benjibc
Copy link
Contributor

@benjibc benjibc commented Oct 2, 2025

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +364 to +365
print(f"\n✓ Selected: {_format_test_choice(tests[selected_index], selected_index + 1)}")
return [tests[selected_index]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore ability to select multiple tests interactively

The new questionary.select flow only ever returns a single index, so _prompt_select_interactive now always returns a list with one test (return [tests[selected_index]]). The CLI upstream (upload_command) and the fallback prompt continue to support selecting multiple tests in one run, which was previously possible with the checkbox UI. With this change a user who discovers several tests must rerun the upload command for each test, making the interactive path functionally inconsistent with the rest of the command. Consider switching back to a multi-select widget or otherwise preserving multi-selection support.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants