Add guarded migration rerun support by ejsmith · Pull Request #2562 · exceptionless/Exceptionless

ejsmith · 2026-09-06T03:41:53Z

Summary

add an explicit opt-in marker and shared service for rerunning completed migrations without changing migration history
expose guarded System Migrations actions with typed confirmation, background execution, and status polling
support the same rerun path from the job CLI with Migration --rerun <id> for instances that cannot start the UI
mark saved-view column migration 5 as rerunnable and document the self-hosted recovery workflow

Addresses #2551.

Safety

only explicitly marked, completed migrations can be rerun
reruns share the normal migration lock and reject concurrent running requests
operation status is tracked separately; the recorded current version and original completion timestamp remain unchanged
operation records precede active markers, and stale reservations plus terminal cleanup are recovered atomically
queued operations are reused for safe UI redispatch or CLI recovery after a process exits before dispatch
interrupted or infrastructure-blocked UI operations are retried by queue redelivery
split Web/Job deployments fail fast unless the UI and worker share a distributed queue and Redis-backed cache
completed, cancelled CLI, and durably recorded migration failures are not rerun automatically

Verification

dotnet build Exceptionless.slnx --no-restore
focused migration retry, migration, CLI parsing, and admin endpoint tests (22 passed)
endpoint manifest and OpenAPI snapshot tests (5 passed)
npm run validate
Playwright System Migrations confirmation flow (1 passed)
local Aspire frontend and browser-facing API health checks

Breaking changes

None.

ejsmith · 2026-09-06T03:44:29Z

@codex review

chatgpt-codex-connector · 2026-09-06T03:44:51Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-08T01:15:59.645373Z	`3a2727d`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef625de5f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejsmith · 2026-09-06T04:05:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32fe6c916e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejsmith · 2026-09-06T04:32:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68507626ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejsmith · 2026-09-06T04:51:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf6befdbf7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejsmith · 2026-09-06T05:03:50Z

@codex review

ejsmith · 2026-09-06T05:05:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b9cffa169

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejsmith · 2026-09-06T05:17:30Z

@codex review

ejsmith · 2026-09-06T05:19:33Z

@codex review

chatgpt-codex-connector · 2026-09-06T05:25:10Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: f7b884d022

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a2727ddeb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-08T01:15:57Z

+            catch (Exception ex)
+            {
+                await migrationRerunService.FailQueuedOperationAsync(operation.Id, ex);
+                throw;


Preserve reused operations when redispatch fails

When the first request has already enqueued an operation but its state is still Queued, a retry reuses that same operation ID; if the retry's EnqueueAsync then fails transiently, this catch marks the shared operation Failed and removes its reservation. The original queued item subsequently encounters the terminal-state guard and exits without running the migration. Track whether QueueAsync created or reused the operation, and only fail a newly created reservation when dispatch fails.

AGENTS.md reference: AGENTS.md:L72-L75

Useful? React with 👍 / 👎.

github-actions · 2026-09-08T01:18:31Z

Package	Line Rate	Branch Rate	Complexity	Health
Exceptionless.Insulation	37%	35%	286	❌
Exceptionless.Web	85%	70%	8102	✔
Exceptionless.Core	76%	68%	10496	✔
Exceptionless.AppHost	38%	41%	147	❌
Summary	79% (26314 / 33335)	68% (12215 / 18003)	19031	✔

Add guarded migration reruns

ef625de

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/Api/Handlers/AdminHandler.cs

Comment thread src/Exceptionless.Core/Migrations/MigrationRerunService.cs Outdated

Address migration rerun recovery feedback

32fe6c9

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread src/Exceptionless.Core/Jobs/WorkItemHandlers/RerunMigrationWorkItemHandler.cs

Comment thread src/Exceptionless.Core/Migrations/MigrationRerunService.cs

Harden migration rerun retries

6850762

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread src/Exceptionless.Core/Migrations/MigrationRerunService.cs Outdated

Comment thread src/Exceptionless.Core/Migrations/MigrationRerunService.cs Outdated

Harden migration rerun dispatch

bf6befd

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread src/Exceptionless.Core/Migrations/MigrationRerunService.cs Outdated

Comment thread src/Exceptionless.Web/Api/Handlers/AdminHandler.cs Outdated

Make rerun reservations recoverable

0b400f7

Retain rerun reservations on state write failure

3b9cffa

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread src/Exceptionless.Core/Migrations/MigrationRerunService.cs Outdated

Redispatch queued migration reruns

164d8e1

Tie rerun cancellation recovery to execution

f7b884d

Merge branch 'main' into issue/rerun-completed-migrations

3a2727d

ejsmith marked this pull request as ready for review September 8, 2026 01:08

ejsmith merged commit bd281c4 into main Sep 8, 2026
11 checks passed

ejsmith deleted the issue/rerun-completed-migrations branch September 8, 2026 01:09

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

ejsmith commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Safety

Verification

Breaking changes

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

ejsmith commented Sep 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 6, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ejsmith commented Sep 6, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 6, 2026 •

edited

Loading