Bump scala-parser-combinators from 2.1.0 to 2.4.0 - #883
Open
rabestro wants to merge 1 commit into
Open
Conversation
Aligns the five exercises that declare the dependency with the version the test runner now provides in its assembly jar (exercism/scala-test-runner#63), and with the 2.4.0 already used by this repo's own root build.sbt for testgen. Before this, a solution resolved 2.1.0 when run locally with sbt and 2.4.0 when submitted to the website. Harmless in practice for the RegexParsers API these exercises use, but there is no reason for the two environments to differ. Verified by running each exercise's example against its test suite, with `pending` stripped, at both versions: alphametics 10, forth 46, matching-brackets 15, sgf-parsing 12 and wordy 16 tests pass either way, with identical compiler warning counts. `configlet lint` passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to exercism/scala-test-runner#63, which fixed #863 by adding
scala-parser-combinatorsto the test runner's assembly jar.That fix went in at
2.4.0, while the five exercises that declare the dependency still pin2.1.0:alphameticsforthmatching-bracketssgf-parsingwordySo a solution resolved 2.1.0 when run locally with
sbtand 2.4.0 when submitted to the website. For theRegexParsersAPI these exercises use that difference is harmless — but there is no reason for the two environments to disagree, and 2.4.0 is what this repo's own rootbuild.sbtalready uses fortestgen.This is a version-only change; no exercise source is touched.
Verification
bin/testcan't run on macOS (it usesmktemp --suffixandsed -i -e, both GNU-only — see #842), so I ran the equivalent on a copy of each exercise: install.meta/Example.scalaover the stub per.meta/config.json, strippending, thensbt test.Run at both versions, the results are identical:
The warnings are pre-existing (pattern-match exhaustivity on
parseAllresults, plus an implicit-conversion feature warning inalphameticsandsgf-parsing); the bump neither adds nor removes any.bin/configlet lintpasses.