Skip to content

Remove Ubuntu from CI workflow, using only macOS for testing #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025

Conversation

meatball133
Copy link
Member

Due to the Ubuntu ci have a tendency to fail (this is due to a dependency which has this as known issue). It is intended to be solved with the next version which seems to be stalled atm. So I decide to disable them for now.

@meatball133 meatball133 added the x:rep/small Small amount of reputation label Jul 12, 2025
Copy link
Contributor

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@meatball133 meatball133 requested a review from a team July 12, 2025 21:23
@BNAndras
Copy link
Member

BNAndras commented Jul 12, 2025

Can we just use the test runner image inside the Linux CI? Otherwise, the CI is testing solutions only on macOS but the test runner is Linux. That doesn’t make a lot of sense.

@IsaacG
Copy link
Member

IsaacG commented Jul 12, 2025

Is can we use a different Linux distro? Is there some specific issue with the runner we could work around? Could we backport the fix?

@BNAndras
Copy link
Member

If can we use a different Linux distro? Is there some specific issue with the runner we could work around? Could we backport the fix?:

The issue is with this GHA we’re using to install Swift 6.0 and 6.1: swift-actions/setup-swift#710.

@IsaacG
Copy link
Member

IsaacG commented Jul 13, 2025

Is there a prior version of that GHA that wasn't broken?

@BNAndras
Copy link
Member

BNAndras commented Jul 13, 2025

https://github.com/swift-actions/setup-swift/releases/tag/v2.2.0 predates when the GPG issue was reported in April (swift-actions/setup-swift#694). That wouldn’t support Swift 6.1 which the test runner targets unfortunately.

@BNAndras
Copy link
Member

Since the issue seems to be getting Swift easily installed, https://hub.docker.com/_/swift/tags?name=6.1 shows several Docker images that would already have it installed.

@glennj
Copy link

glennj commented Jul 13, 2025

Can we just use the test runner image inside the Linux CI? Otherwise, the CI is testing solutions only on macOS but the test runner is Linux. That doesn’t make a lot of sense.

8th does this. https://github.com/exercism/8th/blob/main/.github/workflows/test.yml

There is some admin work required, as there's a secret to be stored.

This also means that development cannot happen in forks (due to access to the secret): you must use branches in the central repo. This reduces the number of potential developers.

@glennj
Copy link

glennj commented Jul 13, 2025

my 2 cents: I would suggest that, as this is "just" for CI, not the test runner, we shouldn't be too worried about the efficiency of the infrastructure. (Unless it's easy to add a docker image into a github CI workflow)

@meatball133
Copy link
Member Author

Can we just use the test runner image inside the Linux CI? Otherwise, the CI is testing solutions only on macOS but the test runner is Linux. That doesn’t make a lot of sense.

Prior to the Swift 6 update which was released last month. It was only macOS testing and it worked totally fine. Also worth mentioning is that I use Linux to make the patches (and I think the other quite active contributor also do) so some Linux testing already occurs. This was mostly intended as a quick temporary fix until the library updates to fix this.

@meatball133 meatball133 merged commit 38321cd into main Jul 20, 2025
6 checks passed
@meatball133 meatball133 deleted the disable-ubuntu-testing branch July 20, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants