-
-
Notifications
You must be signed in to change notification settings - Fork 162
Fixed minor formatting issue in introduction.md #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed ~~~~exercism/warrning ~~~~ surrounding a paragraph and swift code snippet which was causing the ```swift ... ``` tags to be visible in the formatted md file.
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
@@ -81,7 +80,7 @@ var mutVar = 0 | |||
inoutFunc(&mutVar, &mutVar) | |||
// raises a compiler error: "Inout arguments are not allowed to alias each other" | |||
``` | |||
~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may simply require a blank line between the block ends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried adding a blank line between ``` and ~~~~, but it does not format the code snippet.
Also the text ~~~~exercism/warrning
is it correct or it should be ~~~~exercism/warning
? Get same formatting with both of them, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be caution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caution tag is not formatting the code either.
@@ -65,7 +65,6 @@ updateVersion(&dbRecord) | |||
// dbRecord is now (3, "Exercism") | |||
``` | |||
|
|||
~~~~exercism/warrning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue here is that this tag doesn't exist. To fix this, this tag should be: caution not warrning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tags exercism/caution and caution are not working either.
While using Exercism for practice found that the ```swift ... ``` is visible in the introduction guide, which I thought is due to a formatting issue caused due to the surrounding tag ~~~~exercism/warrning ~~~~. Hence removed the tag to format it similarly as other code snippets.
Hope it will be helpful. Thanks.