Skip to content

Conversation

@innovimax
Copy link

No description provided.

@cirulls
Copy link

cirulls commented Jan 17, 2017

@innovimax : Thanks for the contribution. Does this pull request fix the code coverage? This was fixed in XSpec release v0.5.0, the development moved to https://github.com/xspec/xspec (I don't have write permissions on the expath/xspec repository).

I had a quick look at your changes with what is currently implemented in https://github.com/xspec/xspec/blob/master/java/com/jenitennison/xslt/tests/XSLTCoverageTraceListener.java and they look very similar. If you notice anything different or if your pull request also addresses other things, could you initiate a pull request on https://github.com/xspec/xspec so that I can properly check the diff files?

Thanks,

Sandro

@innovimax
Copy link
Author

hello @cirulls !

Yess indeed it has been already fixed (I saw that later and did update my branch after that)

@cirulls
Copy link

cirulls commented Jan 17, 2017

Thanks for confirming. If you have other pull requests or feature requests do not hesitate to send them to https://github.com/xspec/xspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants