feat: add deprecation warnings for invalid sendStatus parameters to prepare for Express v6 #6774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add deprecation warning for non-number status codes in res.sendStatus() - Fallback to status 500 for invalid inputs to maintain backward compatibility - Prepare for stricter validation in Express 6 - Add comprehensive tests for deprecation behavior - Support for undefined, BigInt, and string inputs with graceful fallback Fixes issue with uncaught TypeError when BigInt values are passed to sendStatus() while maintaining backward compatibility through deprecation warnings. Signed-off-by: vedant <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
shivarm
reviewed
Sep 18, 2025
|
|
||
| // Emit deprecation warning for invalid status codes | ||
| if (typeof statusCode !== 'number') { | ||
| deprecate('Invalid status code: ' + String(statusCode) + '. Status code must be a number. This will throw an error in Express 6.'); |
There was a problem hiding this comment.
Suggested change
| deprecate('Invalid status code: ' + String(statusCode) + '. Status code must be a number. This will throw an error in Express 6.'); | |
| deprecate('statusCode must be a valid number to res.sendStatus.'); |
I think keep it simple and only idea is just show deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements deprecation warnings for invalid status codes passed to
res.sendStatus(), as recommended by maintainers. This provides a smooth migration path from the current throwing behavior to stricter validation planned for Express 6.Background
Previously,
res.sendStatus()threw aTypeErrorfor non-number inputs. This PR introduces deprecation warnings for such inputs in Express 5, maintaining backward compatibility while preparing for Express 6, where these inputs will throw errors.Changes Made
depdmoduleundefined,BigInt, andstringinputsString()to safely convert invalid values in warningsBackward Compatibility
Test Results
All 1,242 tests pass, including the new comprehensive sendStatus test coverage validating fallback behavior and deprecation logic.
Implementation Details
depddeprecation system consistent with other Express warnings