-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(#1932): implement smooth scrolling for anchor navigation across site #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bjohansebas
merged 5 commits into
expressjs:gh-pages
from
Mohit5Upadhyay:feat-1932-smooth-scrolling
Aug 2, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ee25a7b
feat(#1932): implement smooth scrolling for anchor navigation across …
Mohit5Upadhyay 736831c
feat: implement CSS-only smooth scrolling for anchor navigation
Mohit5Upadhyay 9ce8ec4
apply reviewer changes: Update scroll-margin-top to 60px and remove p…
Mohit5Upadhyay 6daa170
Merge branch 'gh-pages' into feat-1932-smooth-scrolling
bjohansebas 48aed9e
remove scroll to top functionality and prevent default navigation fo…
bjohansebas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,20 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| -webkit-tap-highlight-color: transparent; | ||
| scroll-behavior: smooth; | ||
| } | ||
|
|
||
| /* handle header offset with scroll-margin */ | ||
| h1, h2, h3, h4, h5, h6, | ||
| [id] { | ||
| scroll-margin-top: 60px; | ||
| } | ||
|
|
||
| /* Respect user motion preferences for access */ | ||
| @media (prefers-reduced-motion: reduce) { | ||
| html { | ||
| scroll-behavior: auto; | ||
| } | ||
| } | ||
|
|
||
| body { | ||
|
|
@@ -258,11 +272,6 @@ a { | |
| padding-top: 40px; | ||
| } | ||
|
|
||
| #api-doc *:target, #page-doc *:target { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I support removing this |
||
| margin-top: -120px; | ||
| padding-top: 120px; | ||
| z-index: -1; | ||
| } | ||
|
|
||
| /* logo */ | ||
| .logo-container a { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.