Skip to content

support node >=18 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 3, 2025
Merged

support node >=18 #1303

merged 7 commits into from
Jun 3, 2025

Conversation

bjohansebas
Copy link
Member

As with other packages, we support Node >=18 🙂 for this new version

@bjohansebas bjohansebas mentioned this pull request May 15, 2025
Open
17 tasks
@ctcpip
Copy link
Member

ctcpip commented May 21, 2025

As with other packages, we support Node >=18 🙂 for this new version

this is not really the case. see non-goals in the ADR

therefore, we should not drop support for older versions if we don't have a reason beyond "it's old node"

ctcpip
ctcpip requested changes May 21, 2025
View reviewed changes
Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

UlisesGascon
UlisesGascon reviewed May 23, 2025
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check if there is a need for engines change once all the dependencies are updated

@UlisesGascon UlisesGascon added this to the 3.0.0 milestone May 23, 2025
@bjohansebas
Copy link
Member Author

@ctcpip We need to update type-is, which supports Node >= 18 :)

@bjohansebas
Copy link
Member Author

bjohansebas commented Jun 2, 2025 •
edited
Loading

see #1329 and #1330

ctcpip
ctcpip reviewed Jun 2, 2025
View reviewed changes
@bjohansebas bjohansebas requested a review from ctcpip June 2, 2025 20:08
UlisesGascon
UlisesGascon approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please don't forget to update the CHANGELOG.md file as this is a breaking change :)

@UlisesGascon UlisesGascon mentioned this pull request Jun 3, 2025
Merged
@bjohansebas
support node >18
618d792 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
support node <13
309e418 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
ci: change branch name
d67976f 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
ci: rename branch in legacy ci
1762115 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
fix coverage
77c5f82 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
update changelog
f6dd683 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
remove node <16
4712138 
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
Copy link
Member Author

@UlisesGascon I’ve already updated the changelog

@UlisesGascon UlisesGascon merged commit 7dd1e55 into expressjs:v3 Jun 3, 2025
30 checks passed
@bjohansebas bjohansebas deleted the ci-express branch June 3, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@ctcpip ctcpip ctcpip approved these changes

@LinusU LinusU Awaiting requested review from LinusU

Assignees

@UlisesGascon UlisesGascon

Labels
semver-major v3.x
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bjohansebas @ctcpip @UlisesGascon