Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node_version: [20.x, 22.x, 23.x]
node_version: [20.x, 22.x, 24.x]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion eval.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { execSync } from 'node:child_process'
import { readFileSync, writeFileSync, existsSync } from 'node:fs'

import { slugify } from 'bellajs'
import { slugify } from '@ndaidong/bellajs'

import { isValid as isValidUrl } from './src/utils/linker.js'
import { extract, extractFromHtml } from './src/main.js'
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "8.0.18",
"version": "8.0.19",
"name": "@extractus/article-extractor",
"description": "To extract main article from given URL",
"homepage": "https://github.com/extractus/article-extractor",
Expand Down Expand Up @@ -31,16 +31,16 @@
},
"dependencies": {
"@mozilla/readability": "^0.6.0",
"bellajs": "^11.2.0",
"@ndaidong/bellajs": "^12.0.1",
"cross-fetch": "^4.1.0",
"linkedom": "^0.18.10",
"sanitize-html": "2.16.0"
},
"devDependencies": {
"@eslint/js": "^9.26.0",
"@types/sanitize-html": "^2.15.0",
"@types/sanitize-html": "^2.16.0",
"eslint": "^9.26.0",
"globals": "^16.0.0",
"globals": "^16.1.0",
"https-proxy-agent": "^7.0.6",
"nock": "^14.0.4"
},
Expand Down
2 changes: 1 addition & 1 deletion src/config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// config.js

import { clone } from 'bellajs'
import { clone } from '@ndaidong/bellajs'

const sanitizeHtmlOptions = {
allowedTags: [
Expand Down
2 changes: 1 addition & 1 deletion src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import {
isString
} from 'bellajs'
} from '@ndaidong/bellajs'

import retrieve from './utils/retrieve.js'
import parseFromHtml from './utils/parseFromHtml.js'
Expand Down
4 changes: 2 additions & 2 deletions src/utils/extractLdSchema.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// utils -> extractLdSchema.js

import { isArray, isObject, isString } from 'bellajs'
import { isArray, isObject, isString } from '@ndaidong/bellajs'

const typeSchemas = [
'aboutpage',
Expand Down Expand Up @@ -74,7 +74,7 @@ export default (document, entry) => {

const keyValue = ldJson[attr]
const val = isArray(keyValue) ? keyValue[0] : isObject(keyValue) ? keyValue?.name || '' : keyValue
if (isString(val)) {
if (isString(val) && val !== '') {
entry[key] = val.trim()
}
})
Expand Down
5 changes: 3 additions & 2 deletions src/utils/extractMetaData.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,9 @@ export default (html) => {

Array.from(doc.getElementsByTagName('meta')).forEach(node => {
const result = getMetaContentByNameOrProperty(node, attributeLists)
if (result) {
entry[result.key] = result.content
const val = result?.content || ''
if (val !== '') {
entry[result.key] = val
}
})

Expand Down
2 changes: 1 addition & 1 deletion src/utils/extractMetaData.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import assert from 'node:assert'

import { readFileSync } from 'node:fs'

import { isObject, hasProperty } from 'bellajs'
import { isObject, hasProperty } from '@ndaidong/bellajs'

import extractMetaData from './extractMetaData.js'

Expand Down
2 changes: 1 addition & 1 deletion src/utils/extractWithReadability.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { Readability } from '@mozilla/readability'
import { DOMParser } from 'linkedom'
import { isString } from 'bellajs'
import { isString } from '@ndaidong/bellajs'

export default (html, url = '') => {
if (!isString(html)) {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/extractWithReadability.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import assert from 'node:assert'

import { readFileSync } from 'node:fs'

import { isString } from 'bellajs'
import { isString } from '@ndaidong/bellajs'

import extractWithReadability, { extractTitleWithReadability } from './extractWithReadability.js'

Expand Down
2 changes: 1 addition & 1 deletion src/utils/html.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { DOMParser } from 'linkedom'
import sanitize from 'sanitize-html'
import { pipe } from 'bellajs'
import { pipe } from '@ndaidong/bellajs'

import { getSanitizeHtmlOptions } from '../config.js'

Expand Down
2 changes: 1 addition & 1 deletion src/utils/html.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import assert from 'node:assert'

import { readFileSync } from 'node:fs'

import { isString } from 'bellajs'
import { isString } from '@ndaidong/bellajs'

import {
cleanify
Expand Down
2 changes: 1 addition & 1 deletion src/utils/linker.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import assert from 'node:assert'

import { readFileSync } from 'node:fs'

import { isString } from 'bellajs'
import { isString } from '@ndaidong/bellajs'

import {
chooseBestUrl,
Expand Down
2 changes: 1 addition & 1 deletion src/utils/parseFromHtml.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// utils -> parseFromHtml

import { stripTags, truncate, unique, pipe } from 'bellajs'
import { stripTags, truncate, unique, pipe } from '@ndaidong/bellajs'

import { purify, cleanify } from './html.js'

Expand Down
2 changes: 1 addition & 1 deletion src/utils/parseFromHtml.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import assert from 'node:assert'

import { readFileSync } from 'node:fs'

import { isFunction } from 'bellajs'
import { isFunction } from '@ndaidong/bellajs'

import { extractFromHtml as parseFromHtml } from '../main.js'
import { addTransformations } from './transformation.js'
Expand Down
2 changes: 1 addition & 1 deletion src/utils/similarity.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// similarity.js
// https://github.com/aceakash/string-similarity

import { isArray, isString } from 'bellajs'
import { isArray, isString } from '@ndaidong/bellajs'

const areArgsValid = (mainString, targetStrings) => {
return isString(mainString) && isArray(targetStrings)
Expand Down
2 changes: 1 addition & 1 deletion src/utils/transformation.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// utils --> transformation.js

import { isArray, isFunction, clone } from 'bellajs'
import { isArray, isFunction, clone } from '@ndaidong/bellajs'
import { DOMParser } from 'linkedom'

const transformations = []
Expand Down
Loading