feat: scaffold v1 #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved ui stuffs to ui package changed frontend build to ui/build embedded build files for serve serve command now serves embedded files dev command runs inertia in dev mode
|
Review changes with Changed Files
|
eznix86
requested changes
Oct 8, 2025
Comment on lines
+1
to
+2
| * | ||
| !.gitignore |
There was a problem hiding this comment.
Can you add ui/build folder to gitignore, you can put a .gitkeep to ui/build/.gitkeep if you want,
Comment on lines
+30
to
+33
| inertia, err := gonertia.NewFromBytes(ui.BuildHtml()) | ||
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
you can use inertia.NewFromFileFS(embedFS, "...") https://github.com/romsar/gonertia?tab=readme-ov-file#basic-example
Comment on lines
+54
to
+62
| in, err := gonertia.NewFromFile("ui/views/app.html") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| i, err := inertia.NewWithVite(in) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } |
There was a problem hiding this comment.
no need for dual func, the inertia.go for vite handle both cases.
Comment on lines
+10
to
+48
| //go:embed views/app.html | ||
| var buildHtml []byte | ||
|
|
||
| func BuildHtml() []byte { | ||
| return buildHtml[:] | ||
| } | ||
|
|
||
| //go:embed build | ||
| var build embed.FS | ||
|
|
||
| func Assets() fs.FS { | ||
| assets, err := fs.Sub(build, "build/assets") | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to get subdirectory %q: %w", "build/assets", err)) | ||
| } | ||
|
|
||
| return assets | ||
| } | ||
|
|
||
| //go:embed build/manifest.json | ||
| var manifest []byte | ||
|
|
||
| type manitestData map[string]struct { | ||
| File string `json:"file"` | ||
| } | ||
|
|
||
| func Manifest() func(name string) (string, error) { | ||
| var data manitestData | ||
| err := json.Unmarshal(manifest, &data) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to unmarshal manifest: %w", err)) | ||
| } | ||
|
|
||
| return func(name string) (string, error) { | ||
| entry, ok := data[name] | ||
| if !ok { | ||
| return "", fmt.Errorf("entry %q not found in manifest", name) | ||
| } | ||
|
|
There was a problem hiding this comment.
no need to handle all of this, as it already handled in the inertia.go for vite
we can have a simple:
//go:embed public/*
var embeddedUI embed.FS
subFS, err := fs.Sub(embeddedFiles, "ui")
and use http.FileServer with it
Can use the ViteConfig with Options Pattern to override behaviour which points to public right now.
Comment on lines
+30
to
+40
| cmdServe := &cobra.Command{ | ||
| Use: "serve", | ||
| Short: "Start the explorer server", | ||
| RunE: serveCommand(logger, "127.0.0.1", 1337, false), | ||
| } | ||
|
|
||
| cmdDev := &cobra.Command{ | ||
| Use: "dev", | ||
| Short: "Start the explorer server in development mode", | ||
| RunE: serveCommand(logger, "127.0.0.1", 1337, true), | ||
| } |
There was a problem hiding this comment.
inertia.go for vite already knows if it is dev or not, it detect the hot file. if it exists, it will call vite for assets to do hot reload. If it doesn't see hot file, it will serve the assets directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffold for Golang with inertiaJS