Some CMake improvements

[LecrisUT]

• Bump the maximum CMake policy
• Use GNUInstallDirs as defaults to simplify donwstream's packaging

The first change could technically be problematic if an old policy is implicitly used, but these are generally unlikely. The motivation for that is to simplify downstream maintenance in the long run. CI builds should pick up any issues

[facebook-github-bot]

Hi @LecrisUT!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[pbhandar2]

Thank you for the PR! Could you explain the reason for bumping cmake version? It sets a minimum of 3.5 but newer versions can be used. I am not sure how the range would work with setting the minimum version of cmake with cmake_minimum_required.

[LecrisUT]

This sets a maximum (tested) cmake version policy. I.e. if you run with any CMake version less than the upper-bound, it will set all its policies to NEW. If you run with a CMake version greater than that, it will set all policies defined up to the upper-bound to NEW.

In practice it says upstream has tested up to this CMake version and all is fine. This reduces the downstream burden having to patch the lower-bound when CMake removes the support for that version (probably next batch is everything below 3.10)