Skip to content

docs(Drawer): record current Lab contract - #6160

Draft
imdreamrunner wants to merge 1 commit into
mainfrom
docs/lab-drawer-current-spec-20260908
Draft

docs(Drawer): record current Lab contract#6160
imdreamrunner wants to merge 1 commit into
mainfrom
docs/lab-drawer-current-spec-20260908

Conversation

@imdreamrunner

@imdreamrunner imdreamrunner commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Why

Drawer has consumer docs and tests but no component-local contract. Before hardening or promotion changes are judged, maintainers need one reviewable baseline for the Lab component that exists on current main.

What

  • Adds colocated draft record component:Drawer at packages/lab/src/Drawer/Drawer.spec.md.
  • Records the current viewport-only side-overlay boundary, controlled visibility, logical edge, sizing/mobile reveal, paired modal-with-scrim and non-modal-without-scrim presentations, focus and exit lifecycle, sibling order, accessibility obligations, resource ownership, and current drawer theming target.
  • Links current architecture, family:overlay-dismissal, and spec:AST-027/DEC-3, naming both Drawer’s local Escape registry and its non-modal show() plus page-level z-index as current conformance gaps rather than approved exceptions.
  • Explicitly excludes regional/pane-scoped placement, a container target, independent modality and scrim axes, docked layout, and block-axis sheets.

Relationship to #5807

#5807 was withdrawn because its bounded/pane-scoped direction was abandoned with the corresponding implementation. This PR does not revive that system spec. It creates the canonical component-local component:Drawer record and describes only today’s viewport-only Lab component.

Risk

Knowledge only. The record remains authority: draft; it changes no runtime, DOM, styling, target, prop, generated artifact, or consumer behavior. No Changeset.

Validation

  • pnpm check:knowledge
  • pnpm check:repo
  • Prettier, staged diff, and public-repository leak checks
  • Current source, consumer docs, tests, architecture:layer-runtime, architecture:public-component-api, architecture:react-component-runtime, architecture:component-theming-surface, and family:overlay-dismissal reconciled

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 8, 2026 4:29pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 8, 2026
@astracat-bot

astracat-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟡 Reviewed (for maintainers only) Sep 9, 2026, 5:07 AM UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant