fix(docsite): prevent stale template previews on opening and reopening

[Angadslr]

Opening a template could briefly render the previous template’s preview while the header already showed the selected template.

Render direct selections immediately, reserving deferred previews for pending previous/next navigation. Retire that preview-pending state when the dialog closes or the selection changes, so unfinished navigation cannot keep a newly selected template covered by its loading skeleton.

Regression coverage

• Opening a non-first template, including fullscreen.
• Closing and reopening another template.
• Direct index changes and initial deep-linked selection.
• Previous/next navigation and its pending skeleton.
• Closing during suspended navigation, then opening a third template before completion.

The new pending-navigation regression fails before the latest correction and passes afterward.

Validation

• All 10 focused tests pass.
• Docsite typecheck passes.
• Changed-file lint passes.

Bug recording

https://youtu.be/DUU9HG8Bk54

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
astryx	Error		Sep 10, 2026 8:21pm UTC

[github-actions]

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.

---

_{Generated by PR Enrichment workflow | Storybook | Sandbox | View full report}

[cixzhang]

The runtime fix correctly prevents the selected template from opening with stale preview content, but this PR also adds an unrelated regression for the earlier dialog-teardown fix.

In template-preview-dialog.test.ts, please remove releases the dialog on playground route hiding and unmount and the Activity / HTMLDialogElement.close harness used only by that case. The call-count assertion locks a private teardown mechanism that this change does not modify, so future dialog lifecycle work could fail a stale-preview suite for an unrelated reason. Keep the opening, direct-selection, and pending-navigation cases that prove this fix and preserve its interaction boundary.

[Reviewed by Robohands]

[Angadslr]

Fixed and pushed. The dialog now renders the selected template immediately while preserving deferred previous/next navigation. Regression tests cover opening, reopening, URL changes, navigation, fullscreen behavior, and Playground teardown.

[astracat-bot]

Thanks for fixing the ordinary stale-open path and removing the unrelated teardown coverage. One stale-preview path remains: if someone closes while previous/next navigation is pending and immediately opens another template, isPending still belongs to the superseded navigation, so the new dialog can render the old deferred preview until that navigation settles. Please make current selection win over superseded work and add a regression for pending navigation → close → open a third card before completion. If you would rather talk it through with someone, we are in Discord.

Superseded by #6167 (review) on exact head 5c3b1d7.

[astracat-bot]

Thanks for fixing the ordinary stale-open path and removing the unrelated teardown coverage. One stale-preview path remains: if someone closes while previous/next navigation is pending and immediately opens another template, isPending still belongs to the superseded navigation, so the new dialog can render the old deferred preview until that navigation settles. Please make current selection win over superseded work and add a regression for pending navigation → close → open a third card before completion. If you would rather talk it through with someone, we are in Discord.

[kentonquatman]

The fix looks great from the design side! Thanks for providing the video showing the bug, it was very helpful!