[Nexthop] Distro CLI: Add proxy device infrastructure for testing #982
Draft
raghav-nexthop wants to merge 7 commits intofacebook:mainfrom
Draft
[Nexthop] Distro CLI: Add proxy device infrastructure for testing #982raghav-nexthop wants to merge 7 commits intofacebook:mainfrom
raghav-nexthop wants to merge 7 commits intofacebook:mainfrom
Conversation
The Distro CLI getip and ssh commands make a best-effort attempt to determine an IP for the given switch based on its MAC address and then either return that IP or directly ssh to it. It does so by connecting to the Distro Infra container and checking on the configured interface for pre-existing IP neighbor/ARP entries. If no such entries are found it will attempt a subnet ping to refresh the Linux kernel neighbor entries. In most cases this is sufficient after the system has PXE booted and therefore the neighbor cache is filled. Testing is as easy as starting the Distro Infra container: ``` $ ./distro_infra.sh --intf eth1 --persist-dir data ``` Then running the fboss-image device getip command with the appropriate MAC address: ``` $ ./fboss-image device dc:da:4d:fc:ad:2d getip [0.00s] Getting IP for device dc:da:4d:fc:ad:2d 10.250.33.2 ```
The fboss-image device image command configures the Distro Infrastructure to PXE boot the given image file for the given device on the next reboot. This replaces the manual steps previously necessary with the MVP Distro Infrastucture. Testing: ``` $ ./fboss-image device dc:da:4d:fc:ad:2d image nh-fboss-broadcom-xgs.tar [0.00s] Setting image for device dc:da:4d:fc:ad:2d: nh-fboss-broadcom-xgs.tar [0.07s] Using persistent directory: /home/travisb/work/upstream/fboss/fboss-image/distro_infra/data [0.07s] Extracting image tarball to /home/travisb/work/upstream/fboss/fboss-image/distro_infra/data/dc-da-4d-fc-ad-2d... [1.96s] Image extracted successfully to /home/travisb/work/upstream/fboss/fboss-image/distro_infra/data/dc-da-4d-fc-ad-2d [1.96s] Enabling PXE boot for MAC address: dc-da-4d-fc-ad-2d [2.09s] Successfully configured device dc:da:4d:fc:ad:2d with image nh-fboss-broadcom-xgs.tar [2.09s] Device is ready for PXE boot ``` Then watch the switch PXE boot on the next boot: ``` >>Checking Media Presence...... >>Media Present...... >>Start PXE over IPv6 on MAC: DC-DA-4D-FC-AD-2D. Press ESC key to abort PXE boot.. Station IP address is FC00:33:0:0:0:FB05:5030:774C Server IP address is FC00:33:0:0:0:0:0:1000 NBP filename is ipxev6.efi NBP filesize is 1158144 Bytes >>Checking Media Presence...... >>Media Present...... Downloading NBP file... NBP file downloaded successfully. iPXE initialising devices... ```
raghav-nexthop
force-pushed
the
distro_cli_3.3_device_update
branch
from
e92d720 to
0353f56
Compare
- Add DeviceUpdater class with component validation - Add COMPONENT_SERVICES mapping for updatable components - Add test manifest and unit tests for validation logic - Stub implementations for artifact acquisition, package creation, and transfer This is the first step in implementing device update functionality.
- Implement full update workflow in DeviceUpdater.update() - Add artifact acquisition via build or download - Add update package creation with update_service.sh script - Add SSH-based transfer and execution on device - Add integration with distro_infra for device IP resolution - Add comprehensive unit tests for update workflow - Add fboss_init.sh support for distro-base snapshot creation
raghav-nexthop
force-pushed
the
distro_cli_3.3_device_update
branch
from
0353f56 to
819e64f
Compare
raghav-nexthop
force-pushed
the
distro_cli_3.3_device_update
branch
from
819e64f to
8f882c7
Compare
- Add Docker-based proxy device container simulating FBOSS services - Add btrfs snapshot support for service root directories - Add systemd service templates for FBOSS services - Add device initialization and entrypoint scripts - Update device_test.py with proxy device integration tests This enables end-to-end testing of device update functionality.
raghav-nexthop
force-pushed
the
distro_cli_3.3_device_update
branch
from
8f882c7 to
44e87d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR adds Docker-based proxy device infrastructure for end-to-end testing of the device update functionality. The following features are provided:
Test Plan
Ran the unit tests. Integration test will be added in the next PR.