Fix #595: Prevent TypedDict kwargs from overlapping with named parameters

[iad1tya]

Closes #595

This PR addresses issue #595 by adding a check in function.rs to prevent TypedDict keys in **kwargs (both direct TypedDict and Unpack[TypedDict]) from overlapping with named parameters, raising a BadFunctionDefinition error. The change is tested in typed_dict.rs with test_typed_dict_kwargs_overlap, covering direct TypedDict, Unpack[TypedDict], and a non-overlapping case. All tests pass, and test.py snapshots are included.

Changes:

• Added overlap check in function.rs for Type::TypedDict and Type::Unpack with TypedDict inner type.
• Updated typed_dict.rs with test_typed_dict_kwargs_overlap to verify both cases and a negative test.
• Verified with cargo test and pyrefly check test.py.

@yangdanny97, please review and let me know if additional cases or changes are needed, especially for Unpack handling. Thanks!

[facebook-github-bot]

Hi @iad1tya!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[iad1tya]

Closes #595

This PR addresses issue #595 by adding a check in function.rs to prevent TypedDict keys in **kwargs (both direct TypedDict and Unpack[TypedDict]) from overlapping with named parameters, raising a BadFunctionDefinition error. The change is tested in typed_dict.rs with test_typed_dict_kwargs_overlap, covering direct TypedDict, Unpack[TypedDict], and a non-overlapping case. All tests pass, and test.py snapshots are included.

Changes:

Added overlap check in function.rs for Type::TypedDict and Type::Unpack with TypedDict inner type.
Updated typed_dict.rs with test_typed_dict_kwargs_overlap to verify both cases and a negative test.
Verified with cargo test and pyrefly check test.py.
@yangdanny97, please review and let me know if additional cases or changes are needed, especially for Unpack handling. Thanks!

[yangdanny97]

Hm, something's off about the whitespace changes in the test file, the whole file looks changed.

[yangdanny97]

this symbol looks odd, somehow &para got replaced by ¶

[yangdanny97]

Oops, forgot to request changes. Back to you with some comments.