Adding dropdown to select the Python version in the sandbox #670

Adist319 · 2025-07-14T22:52:06Z

Addresses #582. Adds the ability to test different Python versions.

This PR implements Python version selection in the sandbox, allowing users to test their code against different Python versions (3.8-3.12) and see how type checking behavior differs across versions.

Adist319 · 2025-07-14T23:00:49Z

I see an unrelated compilation issue/error in dataclass.rs in the CI/CD tests, is this expected?

rchen152 · 2025-07-14T23:14:02Z

Yeah, the build is currently broken - sorry! A fix is being landed and will hopefully be exported to GitHub shortly.

rchen152 · 2025-07-14T23:32:10Z

Yeah, the build is currently broken - sorry! A fix is being landed and will hopefully be exported to GitHub shortly.

Should be fixed by 1546fa9.

… component.

facebook-github-bot · 2025-07-15T16:37:36Z

@migeed-z has imported this pull request. If you are a Meta employee, you can view this in D78350429.

migeed-z · 2025-07-15T22:56:59Z

ci-shell-test-jest is failing. Looking :)

stroxler · 2025-07-16T16:45:09Z

website/src/sandbox/PythonVersionSelector.tsx

+import React from 'react';
+import * as stylex from '@stylexjs/stylex';
+
+const SUPPORTED_VERSIONS = ['3.8', '3.9', '3.10', '3.11', '3.12'] as const;


Should we include 3.13 and 3.14 here?

If I understand correctly, we aren't changing the interpreter version here (which is reasonable, although we need to make sure the UI is clear on this), in which case we might as well use an expansive set of versions, which more easily allows testing newer typeshed features

I can edit. CI is still red on one of the jobs though with a "null pointer passed to rust" error message. I could not repro locally cc'd David in case there are additional thoughts on how to repro

…stract methods. Updated the `AnswersSolver` to handle calls to abstract methods, raising an `AbstractMethodCall` error when such methods are invoked directly.

dluo · 2025-07-17T22:05:04Z

Hi! Sorry for the delay on this review, I looked into the CI error being red and this was the error:

yarn jest
yarn run v1.22.21
$ /data/users/dluo/fbsource/fbcode/pyrefly/website/node_modules/.bin/jest
 PASS  src/__tests__/sandbox.test.tsx
 PASS  src/__tests__/landingPage.test.tsx
 FAIL  src/__tests__/pyrefly_wasm.test.ts
  ● Test suite failed to run

    src/__tests__/__test_utils__/PyreflyWasmTestUtils.ts:36:12 - error TS2554: Expected 1 arguments, but got 0.

    36     return new pyreflyWasmModule.State();
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

      src/__tests__/wasm/pyrefly_wasm_for_testing.js:171:17
        171     constructor(pyrefly_version) {
                            ~~~~~~~~~~~~~~~
        An argument for 'pyrefly_version' was not provided.

Test Suites: 1 failed, 2 passed, 3 total
Tests:       4 passed, 4 total
Snapshots:   4 passed, 4 total
Time:        5.371 s, estimated 6 s
Ran all test suites.
error Command failed with exit code 1.

We have a test which checks some of the wasm behavior, and we need to update the constructor there. Here's the code pointer: https://github.com/facebook/pyrefly/blob/main/website/src/__tests__/__test_utils__/PyreflyWasmTestUtils.ts#L35, we can default this to a hardcoded python version for now (probably 3.12)

migeed-z · 2025-07-17T22:17:57Z

Hi! Sorry for the delay on this review, I looked into the CI error being red and this was the error:
yarn jest
yarn run v1.22.21
$ /data/users/dluo/fbsource/fbcode/pyrefly/website/node_modules/.bin/jest
 PASS  src/__tests__/sandbox.test.tsx
 PASS  src/__tests__/landingPage.test.tsx
 FAIL  src/__tests__/pyrefly_wasm.test.ts
  ● Test suite failed to run

    src/__tests__/__test_utils__/PyreflyWasmTestUtils.ts:36:12 - error TS2554: Expected 1 arguments, but got 0.

    36     return new pyreflyWasmModule.State();
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

      src/__tests__/wasm/pyrefly_wasm_for_testing.js:171:17
        171     constructor(pyrefly_version) {
                            ~~~~~~~~~~~~~~~
        An argument for 'pyrefly_version' was not provided.

Test Suites: 1 failed, 2 passed, 3 total
Tests:       4 passed, 4 total
Snapshots:   4 passed, 4 total
Time:        5.371 s, estimated 6 s
Ran all test suites.
error Command failed with exit code 1.
We have a test which checks some of the wasm behavior, and we need to update the constructor there. Here's the code pointer: https://github.com/facebook/pyrefly/blob/main/website/src/__tests__/__test_utils__/PyreflyWasmTestUtils.ts#L35, we can default this to a hardcoded python version for now (probably 3.12)

Giving this a shot

dluo

Overall code looks good to me, mainly have feedback on the UI. Feel free to also break this up if you would want to commit the wasm portion first (client can just hardcode to a default python version for now)

dluo · 2025-07-17T22:07:09Z

website/src/sandbox/PythonVersionSelector.tsx

+export interface PythonVersionSelectorProps {
+    selectedVersion: string;
+    onVersionChange: (version: string) => void;
+    disabled?: boolean;


nit: call this loading, and we can probably just make this non-optional

dluo · 2025-07-17T22:19:19Z

website/src/sandbox/Sandbox.tsx

+            {!isCodeSnippet && (
+                <div {...stylex.props(styles.versionSelectorContainer)}>
+                    <PythonVersionSelector
+                        selectedVersion={pythonVersion}
+                        onVersionChange={handleVersionChange}
+                        disabled={loading}
+                    />
+                </div>
+            )}


can we actually move the version selector into the buttonContainerBase, we may want to rename that to reflect this change. The main reason is that the current UI looks a bit odd with the selector being in a different place from the buttons, especially on mobile. I think let's try to move it and see if we can make the UI consistent with the buttons as well.

Here's what I see right now of how it looks on mobile + desktop

dluo · 2025-07-17T22:23:31Z

website/src/sandbox/PythonVersionSelector.tsx

+        <select
+            {...stylex.props(styles.versionSelector)}
+            value={selectedVersion}
+            onChange={(e) => onVersionChange(e.target.value)}
+            disabled={disabled}
+            aria-label="Select Python version"
+        >
+            {SUPPORTED_VERSIONS.map((version) => (
+                <option key={version} value={version}>
+                    Python {version}
+                </option>
+            ))}
+        </select>
+    );


The checkmark looks slightly off centred when opening the dropdown, could we fix this?

Adist319 · 2025-07-18T06:24:25Z

@migeed-z Thanks for helping out! Let me know if you want me to take a look at anything, I can take over as well.

…enough.

migeed-z · 2025-07-18T22:10:20Z

@migeed-z Thanks for helping out! Let me know if you want me to take a look at anything, I can take over as well.

can you apply David's comments and then I will be happy to import it and look into it again :)

… into py_version_toggle

facebook-github-bot added the cla signed label Jul 14, 2025

Adist319 added 2 commits July 14, 2025 19:45

Added functionality to handle Python version selection in the Sandbox…

46b5dae

… component.

Run cargo fmt

eb33b41

Adist319 force-pushed the py_version_toggle branch from 0a25a56 to eb33b41 Compare July 15, 2025 02:45

stroxler reviewed Jul 16, 2025

View reviewed changes

Adist319 added 2 commits July 17, 2025 01:35

Introduced a new flag is_abstract_method in FuncFlags to track ab…

0c2cdd7

…stract methods. Updated the `AnswersSolver` to handle calls to abstract methods, raising an `AbstractMethodCall` error when such methods are invoked directly.

run cargo fmt

49fa2df

yangdanny97 requested a review from dluo July 17, 2025 12:57

dluo requested changes Jul 17, 2025

View reviewed changes

Pass by value for is_builtin_module function, as ModuleName is small …

7d86f9e

…enough.

Adist319 and others added 2 commits July 18, 2025 21:56

Merge branch 'facebook:main' into py_version_toggle

114121e

Merge branch 'py_version_toggle' of https://github.com/Adist319/pyrefly…

4aa497b

… into py_version_toggle

yangdanny97 assigned migeed-z Jul 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding dropdown to select the Python version in the sandbox #670

Adding dropdown to select the Python version in the sandbox #670

Adist319 commented Jul 14, 2025

Uh oh!

Adist319 commented Jul 14, 2025

Uh oh!

rchen152 commented Jul 14, 2025

Uh oh!

rchen152 commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 15, 2025

Uh oh!

migeed-z commented Jul 15, 2025

Uh oh!

stroxler Jul 16, 2025

Uh oh!

migeed-z Jul 16, 2025

Uh oh!

dluo commented Jul 17, 2025

Uh oh!

migeed-z commented Jul 17, 2025

Uh oh!

dluo left a comment

Uh oh!

dluo Jul 17, 2025

Uh oh!

dluo Jul 17, 2025

Uh oh!

dluo Jul 17, 2025

Uh oh!

Adist319 commented Jul 18, 2025 •

edited

Loading

Uh oh!

migeed-z commented Jul 18, 2025

Uh oh!

Uh oh!

Adding dropdown to select the Python version in the sandbox #670

Are you sure you want to change the base?

Adding dropdown to select the Python version in the sandbox #670

Conversation

Adist319 commented Jul 14, 2025

Uh oh!

Adist319 commented Jul 14, 2025

Uh oh!

rchen152 commented Jul 14, 2025

Uh oh!

rchen152 commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 15, 2025

Uh oh!

migeed-z commented Jul 15, 2025

Uh oh!

stroxler Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

migeed-z Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

dluo commented Jul 17, 2025

Uh oh!

migeed-z commented Jul 17, 2025

Uh oh!

dluo left a comment

Choose a reason for hiding this comment

Uh oh!

dluo Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

dluo Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

dluo Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Adist319 commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

migeed-z commented Jul 18, 2025

Uh oh!

Uh oh!

Adist319 commented Jul 18, 2025 •

edited

Loading