Skip to content

Conversation

carlosalmonte04
Copy link

@carlosalmonte04 carlosalmonte04 commented Jul 7, 2025

Summary:

Allow usage of environment variable RCT_HERMES_OVERRIDE_GITHUB_URL. Allows for react native apps to use a custom copy of hermes.

When trying to do a security assessment of hermes I ran into issues when trying to use hermes using a local clone of the repo. I was attempting to point react native to my local copy of hermes and ran into an issue. Due to this I decided to point to my fork of hermes on github and I was able to succesfully run the app using my custom fork.

Changelog:

[GENERAL] [ADDED] - Allow to run hermes from a custom github url

Test Plan:

  1. Remove pods: rm -rf ./ios/Pods
  2. Install them using environment variables: RCT_BUILD_HERMES_FROM_SOURCE=true RCT_HERMES_OVERRIDE_GITHUB_URL=https://github.com/carlosalmonte04/hermes.git pod install
  3. Run react-native run-ios

- This allows for a custom Hermes to be used in react native app
- This is helpful when needing to share custom Hermes
@facebook-github-bot
Copy link
Contributor

Hi @carlosalmonte04!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants