Add the ability to provide a custom url for hermes #52459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow usage of environment variable
RCT_HERMES_OVERRIDE_GITHUB_URL
. Allows for react native apps to use a custom copy of hermes.When trying to do a security assessment of hermes I ran into issues when trying to use hermes using a local clone of the repo. I was attempting to point react native to my local copy of hermes and ran into an issue. Due to this I decided to point to my fork of hermes on github and I was able to succesfully run the app using my custom fork.
Changelog:
[GENERAL] [ADDED] - Allow to run hermes from a custom github url
Test Plan:
rm -rf ./ios/Pods
RCT_BUILD_HERMES_FROM_SOURCE=true RCT_HERMES_OVERRIDE_GITHUB_URL=https://github.com/carlosalmonte04/hermes.git pod install
react-native run-ios