fix: React.use inside React.lazy-ed component on SSR
#33941
+81
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @acdlite |
|
cc @eps1lon |
|
Comparing: dffacc7...dc09e25 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
React.useinsideReact.lazy-ed component returns otherReact.usevalue on SSR #33937As indicated by the previous issue comment #27731 (comment), it looks like legacy "throw thenable"-based suspense implementation (used by React.lazy) causes an issue with
React.usebased suspense implementation, which relies onthenableStatehook state tracking.The PR fixes the issue by avoiding
getThenableStateAfterSuspendingwhen legacy "throw thenable" style suspension happened. I tried a different approach such as resettingtask.thenableState = nullduringrenderLazyComponent, but it broke one test caseuseActionState can return binary state during MPA form submissioninpackages/react-server-dom-webpack/src/__tests__/ReactFlightDOMForm-test.js.(By no means, I'm confident with the change, but I thought poking around the code provides better insight for short term workaround. See #33937 (comment). I'd appreciate any help on the issue.)
How did you test this change?
I added a test case in
packages/react-dom/src/__tests__/ReactDOMFizzServer-test.jsbased on the reproduction of the issue (and also #33938).