[Runtime] Fix CI

[eps1lon]

Matches

react/compiler/packages/eslint-plugin-react-compiler/__tests__/ReactCompilerRule-test.ts

Lines 244 to 275 in e985c06

	{
	name: 'Pipeline errors are reported',
	code: normalizeIndent`
	import useMyEffect from 'useMyEffect';
	import {AUTODEPS} from 'react';
	function Component({a}) {
	'use no memo';
	useMyEffect(() => console.log(a.b), AUTODEPS);
	return <div>Hello world</div>;
	}
	`,
	options: [
	{
	environment: {
	inferEffectDependencies: [
	{
	function: {
	source: 'useMyEffect',
	importSpecifierName: 'default',
	},
	autodepsIndex: 1,
	},
	],
	},
	},
	],
	errors: [
	{
	message: /Cannot infer dependencies of this effect/,
	},
	],
	},

#33800 conflicted with https://github.com/facebook/react/pull/33751/files#diff-97f51f298984cfcdbb6068bbe1985c312017015c9baca674d6daec451a43fe50R247

Not sure if we need to duplicate packages/eslint-plugin-react-hooks/__tests__/ReactCompilerRule-test.ts and compiler/packages/eslint-plugin-react-compiler/__tests__/ReactCompilerRule-test.ts. Ideally we'd only have compiler/packages/eslint-plugin-react-compiler/__tests__/ReactCompilerRule-test.ts so that compiler issues don't infect the runtime pipeline.

A failing runtime pipeline blocks nightly releases.

[josephsavona]

thanks, i was just looking into this too but the tests won't run locally for me

[josephsavona]

Not sure if we need to duplicate packages/eslint-plugin-react-hooks/tests/ReactCompilerRule-test.ts and compiler/packages/eslint-plugin-react-compiler/tests/ReactCompilerRule-test.ts. Ideally we'd only have compiler/packages/eslint-plugin-react-compiler/tests/ReactCompilerRule-test.ts so that compiler issues don't infect the runtime pipeline.

We are in the process of consolidating these packages. The compiler and runtime are integrated so i don't think it's reasonable to expect that we can wall them off from in terms of test impact. But we can mitigate this, one approach might be to move the linter into compiler/packages/. cc @poteto @mofeiZ