-
Notifications
You must be signed in to change notification settings - Fork 6
Metrics dashboard api #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MiroDudik
wants to merge
10
commits into
fairlearn:master
Choose a base branch
from
MiroDudik:metrics-dashboard-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
794a07d
add metrics API proposal
MiroDudik 3b93629
add clarifications and confusion_matrix
MiroDudik 9359f13
fix list markdown
MiroDudik ddde2ff
rename _by_group to _group_summary for consistency
MiroDudik 0b86e6d
remove dashboard questions
MiroDudik ace56ba
start proposal for metrics/dashboard api
MiroDudik afa5890
Merge branch 'master' of https://github.com/fairlearn/fairlearn-propo…
MiroDudik 92ea6fd
Merge branch 'master' into metrics-dashboard-api
MiroDudik 366c3e0
flatten the dictionary
MiroDudik c3172e2
close code block
MiroDudik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
# Proposal for metrics/dashboard API | ||
|
||
Goals: | ||
* Unified treatment of many different kinds of metrics in dashboard | ||
* A clean separation between dashboard (for visualization) and different kinds of backends (for metric calculation) | ||
|
||
Status quo: | ||
* Dashboard currently keeps track of the metric values in the cache dictionary `fairlearn.widget._fairlearn_widget.FairlearnWidget._response` | ||
* The dictionary is updated in `fairlearn.widget._fairlearn_dashboard.FairlearnDashboard._on_request` | ||
* There's a PR out to fill the whole data structure in `fairlearn.metrics.create_dashboard_dictionary` | ||
|
||
Issues with the status quo: | ||
* Code duplication / redundancy / brittleness due to copy-paste errors | ||
* Currently only one kind of a metric (`<metric>_summary`) is supported and hard-wired into the dashboard dictionary | ||
|
||
## Proposal | ||
|
||
### Part I: More general dashboard dictionary | ||
|
||
``` | ||
{ | ||
"prediction_type": "binary_classification" or "probabilistic_binary_classification" or "regression", | ||
"y_true": float[], | ||
"y_pred": float[][], | ||
MiroDudik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
"sensitive_features": [ | ||
{ | ||
"column_name": String, | ||
"column_data": int[], | ||
"value_names": string[] | ||
}, | ||
... | ||
], | ||
"metrics": [ | ||
[ | ||
{ | ||
"<metric_fct>" : <metric_result_dict>, | ||
... | ||
}, | ||
... | ||
] | ||
] | ||
} | ||
``` | ||
|
||
Where `metrics[i][j]["<metric_fct>"]` should correspond to the result of the call | ||
``` | ||
<metric_fct>(y_true, y_pred[i], sensitive_features[j]) | ||
MiroDudik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
``` | ||
If the result of the call is a dictionary, then we use that dictionary as `<metric_result_dict>`. If the result is a scalar `x`, we could use the dictionary `{ "value": x }`. | ||
MiroDudik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
#### What's still missing here: | ||
|
||
The above is incomplete, because we need to enable caching results for the calls of the form | ||
``` | ||
<metric_fct>(y_true, y_pred[i], sensitive_features[j], arg1=val_arg1, arg2=val_arg2, ...) | ||
MiroDudik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
``` | ||
One idea would be to use something like: | ||
``` | ||
{ | ||
"<metric_fct>": [ | ||
{ | ||
"arguments": { "arg1": val_arg1, "arg2": val_arg2, ...}, | ||
"result": <metric_result_dict> | ||
}, | ||
... | ||
] | ||
} | ||
``` | ||
|
||
|
||
### Part II: How to remove duplication | ||
|
||
`<TODO>` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we're omitting multiclass classification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we don't have any support for it yet, but we can definitely add other prediction types in future.