Skip to content

perf: remove intermediate list creation when constructing the error list #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

perf: remove intermediate list creation when constructing the error list #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87e2226
perf: remove intermediate list creation when constructing the error list
gurgunday Jun 29, 2025
264feb4
move note to correct place
gurgunday Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions index.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,19 @@ export const TypeBoxValidatorCompiler: FastifySchemaCompiler<TSchema> = ({ schem
if (typeCheck.Check(converted)) {
return { value: converted }
}
const errors = [...typeCheck.Errors(converted)]
const errors = []
for (const error of typeCheck.Errors(converted)) {
errors.push({
message: error.message,
instancePath: error.path
})
}
return {
// Note: Here we return a FastifySchemaValidationError[] result. As of writing, Fastify
// does not currently export this type. Future revisions should uncomment the assertion
// below and return the full set of properties. The specified properties 'message' and
// 'instancePath' do however result in a near equivalent error messages to Ajv.
error: errors.map((error) => ({
message: `${error.message}`,
instancePath: error.path
})) // as FastifySchemaValidationError[]
error: errors // as FastifySchemaValidationError[]
}
}
}
Expand Down