add ServeManyOptionsFromContext, add serve-many e2e test #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fsthttp.ServeMany() is called, we now associate the options with the context that gets passed to handlers. ServeManyOptionsFromContext() allows handlers to retrieve those options and modify them. A new end-to-end test demonstrates this (and allows us to test the reusable session functionality). One possible use case for this is for Compute applications to monitor their heap usage, and reset ServeManyOptions.MaxRequests to 1 if it crosses some threshold to ensure that no more requests are handled by that session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fsthttp.ServeMany() is called, we now associate the options with
the context that gets passed to handlers. ServeManyOptionsFromContext()
allows handlers to retrieve those options and modify them.
A new end-to-end test demonstrates this (and allows us to test the
reusable session functionality).
One possible use case for this is for Compute applications to monitor
their heap usage, and reset ServeManyOptions.MaxRequests to 1 if it
crosses some threshold to ensure that no more requests are handled by
that session.