Deployment optimisation #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xYasser
reviewed
Apr 28, 2023
| allowed_telegram_usernames = config_yaml["allowed_telegram_usernames"] | ||
| env_allowed_users = os.environ.get('ALLOWED_TELEGRAM_USERNAMES', '') | ||
| allowed_telegram_usernames = (lambda s: s.split(',') if s else [])(os.environ.get('ALLOWED_TELEGRAM_USERNAMES', '')) | ||
| new_dialog_timeout = config_yaml["new_dialog_timeout"] |
There was a problem hiding this comment.
this does not have a default value. it should be
new_dialog_timeout = config_yaml.get("new_dialog_timeout", 600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've been working in the last two days on optimizing this wonderful project for deployment on Railway. I've decided to go with that PaaS because it is very intuitive, even for people that don't have a lot of knowledge about this kind of stuff. From what I've observed, my changes have not impaired the functioning of the bot in any way. But it is hard to say without a test suite, so extra caution should be paid.
I'm not a python developer, so sorry if I didn't do everything idiomatically. Please, feel free to give any pointers to improve my code.
Here is a list of my changes: