Add gpt4-vision feature. #395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix argument of type 'float' is not iterable fix "argument of type 'float' is not iterable" in show_balance_handle and message_handle * Update bot.py
Co-authored-by: Flop <[email protected]>
|
Hello, I hope you're doing well! First of all, I want to thank you for your valuable suggestions. They are incredibly helpful! I've decided to implement your suggestions by adding a history conversation feature, allowing users to review previous dialogues. It's going to be so convenient! Additionally, I will modify the scope of the message variable to make it more flexible. This is fantastic!
By the way, I have a question. Why can't I see your comments on this pull request? (Please forgive my newbie mistakes when I first started contributing).
Add gpt4-vision feature. by lvmax1998 · Pull Request #395 · karfly/chatgpt_telegram_bot (github.com)?
Well, that's all for now! Looking forward to hearing from you!
Sent from Mail for Windows
From: Igor Udot
Sent: 2023年11月22日 16:28
To: karfly/chatgpt_telegram_bot
Cc: lvmax1998; Mention
Subject: Re: [karfly/chatgpt_telegram_bot] Add gpt4-vision feature. (PR #395)
Hello, @lvmax1998. As I see, there is no history for user messages. It gets cleaned when the "done" function is called here. But what if it is not called or an error occurs? In that case, the content will still be here.
https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L150
Also, on the other hand, what do you think about moving a variable from the global scope?
https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L16C13-L16C13
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I think it's because I used comments in the code instead of starting a review or something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.