Conversation
Handle HTML tokenizer edge cases by accepting comment closes on --!>, recognizing closing tags that end with / before >, resetting special-tag state correctly, and waiting for ?> in XML processing instructions. Expand tokenizer and parser regression coverage for those cases, update affected snapshots, and exclude test-only fixtures and snapshots from the published package.
There was a problem hiding this comment.
Pull request overview
This PR updates the tokenizer to better match HTML/XML edge-case behavior per spec, and adjusts/adds snapshot coverage to lock in the new parsing semantics.
Changes:
- Allow HTML comments to close on
--!>(while still accepting-->). - Treat
/as a valid “tag section terminator” to support end tags like</div/>(including within special tags). - In XML mode, terminate processing instructions only on
?>, and reset internal special-tag state correctly on.reset().
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Tokenizer.ts | Implements the new edge-case tokenization rules (comment close, end-tag /, PI ?>, reset behavior). |
| src/Tokenizer.spec.ts | Adds test coverage for the new edge cases and reset behavior. |
| src/Parser.events.spec.ts | Adds event-level coverage for special end tags ending in />. |
| src/snapshots/Tokenizer.spec.ts.snap | Updates snapshots for new tokenizer behaviors. |
| src/snapshots/Parser.events.spec.ts.snap | Updates snapshots for new event sequences/indices. |
| src/snapshots/WritableStream.spec.ts.snap | Updates snapshots impacted by processing-instruction termination changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| } else if (c === CharCodes.Gt && this.sequenceIndex === 1) { | ||
| this.cbs.onprocessinginstruction( | ||
| this.sectionStart, | ||
| this.index - 1, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the following tokenizer edge cases to match the HTML spec:
--!>,/before>(e.g.</div/>),.reset()special-tag state correctly, and?>in XML processing instructions.